Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Institution profile] Page-level error for API issues #1031

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Institution profile] Page-level error for API issues #1031

wants to merge 1 commit into from
+22 −12

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented Oct 28, 2024 •
edited
Loading

Closes #1030

Changes

  • Render page-level error alert for API errors, as opposed to rendering a separate 500 page

How to test this PR

  1. Block API requests from the following source in Chrome dev tools:
    1. localhost:8881/v1/institutions/123456789TESTBANK123
  2. Visit http://localhost:8899/institution/123456789TESTBANK123
  3. Observe that things reflect the screenshot below.

Screenshots

Screenshot 2024-11-06 at 4 56 08 PM

@meissadia meissadia changed the title 1030 institution profile page level error [Institution profile] Page-level error for API issues Oct 28, 2024
@natalia-fitzgerald
Copy link

@meissadia
Can we update this error to show this?
Screenshot 2024-11-06 at 10 58 46 AM

@meissadia meissadia force-pushed the 1030-institution_profile-page_level_error branch from b83c959 to 76edbea Compare November 6, 2024 23:59
@meissadia meissadia marked this pull request as ready for review November 7, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

@tanner-ricks tanner-ricks Awaiting requested review from tanner-ricks tanner-ricks is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[View Institution profile] Page level error alerts
2 participants
@meissadia @natalia-fitzgerald