210 Cast counts as ints #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
jcadam14
reviewed
Jun 12, 2024
| ) | ||
|
|
||
| return Counts( | ||
| single_field_count=single_errors, | ||
| multi_field_count=multi_errors, | ||
| register_count=register_errors, | ||
| total_count=sum([single_errors, multi_errors, register_errors]), | ||
| total_count=int(sum([single_errors, multi_errors, register_errors])), |
There was a problem hiding this comment.
Don't need to cast here because single_errors, multi_errors and register_errors are already ints. The reason the above cast has to happen is the sum([(~error.check_output).sum()...]) stuff is returning an int64 from sum(). The sum method returns the type provided here you're summing ints, so an int is returned.
| ), Counts( | ||
| single_field_count=single_warnings, | ||
| multi_field_count=multi_warnings, | ||
| total_count=sum([single_warnings, multi_warnings]), # There are no register-level warnings at this time | ||
| total_count=int(sum([single_warnings, multi_warnings])), # There are no register-level warnings at this time |
jcadam14
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #210