Replace xdr with raw fetch #8626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return data; | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| return Promise.all(promises); |
There was a problem hiding this comment.
Do we need Promise.all(…) any longer, or can solely promises be returned? Not tested, but looking at the code it looks like we may have Promise.all(…) in there because the code had new Promise(…) and also the reference to xdr, which maybe created a promise of its own?
There was a problem hiding this comment.
getData allows ; separated urls as source data and returns a single promise when they're all resolved. To preserve semantics, I think we should keep this as is.
anselmbradford
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the ajax code in chartbuilder to use raw fetch so we can remove xdr (then removes it).