Update linters #8621
Merged
Update linters #8621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anselmbradford
commented
Oct 30, 2024
| // TODO: remove when gulp build config is updated to handle spread operator. | ||
| // eslint-disable-next-line prefer-object-spread | ||
| this.chart = Highcharts.mapChart(el, Object.assign({}, this.chartOptions)); |
There was a problem hiding this comment.
prefer-object-spread isn't set by default in @eslint.js.configs.recommended. However, we could enable it with prefer-object-spread: [error] in the rules and it'll auto-update this to the spread operator.
anselmbradford
force-pushed
the
ans_update_eslint
branch
from
87a1a5a
to
b5e4d02
Compare
wpears
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
[email protected][email protected]eslint-plugin-cypressHow to test this PR
yarn lintshould pass.npx @eslint/config-inspector