Merge pull request #7893 from cfpb/ans_pfc_css

Paying for College: Clean up CSS
cfpb · Aug 9, 2023 · d02241b · d02241b
2 parents fe9fcd6 + b4c700c
commit d02241b
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 44 deletions.
diff --git a/cfgov/unprocessed/apps/paying-for-college/css/cf-enhancements.less b/cfgov/unprocessed/apps/paying-for-college/css/cf-enhancements.less
@@ -108,7 +108,7 @@
   padding-left: @char-icon-size + @char-icon-spacing;
   position: relative;
 
-  &:before {
+  &::before {
     display: block;
     box-sizing: border-box;
     width: @char-icon-size;
@@ -126,34 +126,34 @@
     text-indent: 0;
   }
 
-  &__1:before {
+  &__1::before {
     content: '1';
   }
-  &__2:before {
+  &__2::before {
     content: '2';
   }
-  &__3:before {
+  &__3::before {
     content: '3';
   }
-  &__4:before {
+  &__4::before {
     content: '4';
   }
-  &__5:before {
+  &__5::before {
     content: '5';
   }
-  &__6:before {
+  &__6::before {
     content: '6';
   }
-  &__7:before {
+  &__7::before {
     content: '7';
   }
-  &__8:before {
+  &__8::before {
     content: '8';
   }
-  &__9:before {
+  &__9::before {
     content: '9';
   }
-  &__0:before {
+  &__0::before {
     content: '0';
   }
 }
@@ -168,7 +168,7 @@
     .char-icon();
   }
 
-  & > li:before {
+  & > li::before {
     content: counter(steps);
   }
 }
@@ -187,7 +187,7 @@
     padding-bottom: unit(30px / @base-font-size-px, em);
   });
 
-  &:after {
+  &::after {
     display: block;
     width: 9999px;
     height: 9999px;
@@ -227,7 +227,7 @@
   }
 
   &__bleed {
-    &:after {
+    &::after {
       .respond-to-min(@bp-med-min, {
         padding-right: @grid_gutter-width * 2;
         left: -@grid_gutter-width;
@@ -251,7 +251,7 @@
       padding-bottom: unit(30px / @base-font-size-px, em);
     });
 
-    &:after {
+    &::after {
       display: none;
 
       .respond-to-min(@bp-sm-min, {
@@ -266,7 +266,7 @@
       padding-bottom: unit(50px / @base-font-size-px, em);
     });
 
-    &:after {
+    &::after {
       background-color: @gray-5;
     }
   }
@@ -276,6 +276,6 @@
    Accessible bleedbar
    ========================================================================== */
 
-.content__bleedbar .content_wrapper:after {
+.content__bleedbar .content_wrapper::after {
   background-color: @gray-5;
 }
diff --git a/cfgov/unprocessed/apps/paying-for-college/css/college-costs/college-costs.less b/cfgov/unprocessed/apps/paying-for-college/css/college-costs/college-costs.less
@@ -3,7 +3,7 @@
   & .content_main {
     position: relative;
 
-    &:after {
+    &::after {
       content: none;
     }
   }
@@ -153,7 +153,7 @@
           letter-spacing: normal;
           margin-bottom: 0;
         }
-        dd:after {
+        dd::after {
           height: unit(@grid_gutter-width / 3 / @base-font-size-px, em);
         }
       }

diff --git a/cfgov/unprocessed/apps/paying-for-college/css/college-costs/state-based.less b/cfgov/unprocessed/apps/paying-for-college/css/college-costs/state-based.less
@@ -357,9 +357,7 @@ main.college-costs {
     }
   }
 
-  &:not([data-state_programprogress='0']):not(
-      [data-state_programprogress='n']
-    ) {
+  &:not([data-state_programprogress='0'], [data-state_programprogress='n']) {
     [data-state-based-visibility='is_first_year-false'] {
       display: block;
     }

diff --git a/cfgov/unprocessed/apps/paying-for-college/css/disclosures.less b/cfgov/unprocessed/apps/paying-for-college/css/disclosures.less
@@ -68,8 +68,8 @@
 }
 
 // A bottom border for the sections in step 3 that use a special grid (11 columns plus bleeding into one gutter)
-.offer-part:after,
-.criteria_wrapper:after {
+.offer-part::after,
+.criteria_wrapper::after {
   .respond-to-min( @bp-sm-min, {
     display: block;
     height: 1px;
@@ -98,7 +98,7 @@
   background-image: url('/static/apps/paying-for-college/img/intro-195.png');
 }
 
-@media (-webkit-min-device-pixel-ratio: 2), (min-resolution: 192dpi) {
+@media (min-resolution: 192dpi) {
   .understanding-financial-aid-offer .m-hero_image {
     background-image: url('/static/apps/paying-for-college/img/intro-390.png');
   }
@@ -697,7 +697,7 @@
     } );
   }
 
-  .column-well:after {
+  .column-well::after {
     background-color: @gold-20;
   }
 }
@@ -716,7 +716,7 @@
     background-color: @gold-20;
   }
 
-  .column-well:after {
+  .column-well::after {
     background-color: @gold-40;
   }
 }
@@ -834,7 +834,7 @@
       .grid_nested-col-group();
     } );
 
-    &:after {
+    &::after {
       .respond-to-range( @bp-sm-min, @bp-graph-cols-min - 1, {
         display: none;
       } );
@@ -938,7 +938,7 @@
     } );
   }
 
-  &.column-well__not-stacked:after {
+  &.column-well__not-stacked::after {
     .respond-to-range( @bp-sm-min, @bp-graph-cols-min - 1, {
       display: none;
     } );
@@ -1291,7 +1291,7 @@
 
     &_sign {
       .grid_column(3,24);
-      border-width: 0px;
+      border-width: 0;
 
       .respond-to-min( @bp-med-min, {
         .grid_column(3);
@@ -1534,7 +1534,7 @@
     background-image: url('/static/apps/paying-for-college/img/work-while-studying_150.png');
   }
 
-  @media (-webkit-min-device-pixel-ratio: 2), (min-resolution: 192dpi) {
+  @media (min-resolution: 192dpi) {
     &__maximize-grants {
       background-image: url('/static/apps/paying-for-college/img/maximize-grants_300.png');
     }

diff --git a/cfgov/unprocessed/apps/paying-for-college/css/print.css b/cfgov/unprocessed/apps/paying-for-college/css/print.css
@@ -66,10 +66,10 @@ a.ec,
 a.ec-blk {
   font-weight: 500;
   text-decoration: none;
-  padding-left: 0px;
+  padding-left: 0;
   background-repeat: no-repeat;
-  background-position-x: 0px;
-  background-position-y: 0px;
+  background-position-x: 0;
+  background-position-y: 0;
 }
 
 a.collapse {
@@ -103,7 +103,7 @@ h2 {
   text-transform: uppercase;
   font-size: 14px;
   font-weight: 500;
-  margin-bottom: 0px;
+  margin-bottom: 0;
   line-height: 18px;
 }
 
@@ -143,7 +143,7 @@ td {
   line-height: 20px;
   text-align: center;
   font-weight: 500;
-  padding: 10px 0px 10px;
+  padding: 10px 0;
 }
 
 .lc {
@@ -153,7 +153,7 @@ td {
 .nc {
   text-transform: none;
   font-weight: 500;
-  letter-spacing: 0px;
+  letter-spacing: 0;
   margin-bottom: -0.3em;
 }
 
@@ -167,16 +167,16 @@ td {
 }
 
 table {
-  border: 0px;
+  border: 0;
   border-collapse: separate;
-  border-spacing: 18px 0px;
+  border-spacing: 18px 0;
   padding-bottom: 20px;
 }
 
 td,
 th {
   vertical-align: top;
-  padding: 10px 0px 10px;
+  padding: 10px 0;
   text-align: left;
 }
 
@@ -204,12 +204,12 @@ ol li {
 table th {
   background: transparent;
   color: #212121;
-  border: 0px;
+  border: 0;
   text-align: left;
 }
 
 table td {
-  border: 0px;
+  border: 0;
 }
 
 /* Modals */
@@ -228,8 +228,6 @@ table td {
   line-height: 26px;
   font-size: 1.5em;
   border-radius: 100%;
-  -moz-border-radius: 100%;
-  -webkit-border-radius: 100%;
   margin-right: 5px;
   font-weight: 600;
   margin-top: -6px;