Merge pull request #7881 from cfpb/josh_stylelint_upgrade

Upgrade to [email protected]

.stylelintrc.cjs

@@ -2,32 +2,62 @@
 at-rule-no-unknown -
   This rule enforces only @ rules that appear in the CSS spec,
   however, @plugin appears in Less, so should be ignored.
-rule-empty-line-before -
-  Custom setting that differs from stylelint-config-standard.
+color-function-notation -
+  Set to 'legacy' to support older browsers in our browserslist (for now).
+declaration-block-no-redundant-longhand-properties -
+  Turned off.
+  TODO: Turn on this rule and work out longhand properties.
+declaration-empty-line-before -
+  Turned off.
+  TODO: Turn on this rule and work out what style we want.
+declaration-property-value-no-unknown -
+  Turned off for Less per documentation guidance.
+function-no-unknown -
+  Ignore the 'unit' helper function that comes from Less.
+media-feature-range-notation -
+  Prefer prefixed values, since Less doesn't support ranges.
 no-descending-specificity -
   Turned off, but probably shouldn't be.
   TODO: Turn on this rule and see if issues can be fixed.
+number-max-precision -
+  TODO: See if long decimal values can be shortened using the unit helper.
+rule-empty-line-before -
+  Custom setting that differs from stylelint-config-standard.
+selector-id-pattern -
+  Turned off.
+  TODO: Turn on this rule and work out regex for BEM syntax.
+selector-class-pattern -
+  Turned off.
+  TODO: Turn on this rule and work out regex for BEM syntax.
 less/color-no-invalid-hex
 less/no-duplicate-variables
   Both of the above settings are turned off till
   https://github.com/ssivanatarajan/stylelint-less/issues/6 is addressed.
 */
 module.exports = {
-  extends: ['stylelint-config-recommended-less', 'stylelint-config-prettier'],
+  extends: ['stylelint-config-standard'],
+  plugins: ['stylelint-less'],
   ignoreFiles: ['packages/**/node_modules/**/*.less'],
   customSyntax: 'postcss-less',
   rules: {
     'at-rule-no-unknown': [true, { ignoreAtRules: 'plugin' }],
+    'color-function-notation': ['legacy'],
+    'declaration-block-no-redundant-longhand-properties': null,
     'declaration-empty-line-before': null,
-    'function-name-case': ['lower', { ignoreFunctions: ['filter'] }],
+    'declaration-property-value-no-unknown': null,
+    'function-no-unknown': [true, { ignoreFunctions: ['unit'] }],
+    'media-feature-range-notation': ['prefix'],
+    'no-descending-specificity': null,
+    'number-max-precision': 10,
     'rule-empty-line-before': [
       'always-multi-line',
       {
         except: 'first-nested',
         ignore: ['after-comment', 'inside-block'],
       },
     ],
-    'no-descending-specificity': null,
+    'selector-id-pattern': null,
+    'selector-class-pattern': null,
     'less/color-no-invalid-hex': null,
     'less/no-duplicate-variables': null,
   },

package.json

@@ -18,18 +18,18 @@
   "browserslist": "> 0.5%, Chrome >= 76, Edge >= 98, Firefox >= 78, safari >= 12, not dead",
   "dependencies": {
     "@cfpb/cfpb-analytics": "0.1.4",
-    "@cfpb/cfpb-atomic-component": "0.27.3",
-    "@cfpb/cfpb-buttons": "0.27.3",
-    "@cfpb/cfpb-core": "0.27.3",
-    "@cfpb/cfpb-expandables": "0.27.3",
-    "@cfpb/cfpb-forms": "0.27.3",
-    "@cfpb/cfpb-grid": "0.27.0",
-    "@cfpb/cfpb-icons": "0.27.3",
-    "@cfpb/cfpb-layout": "0.27.3",
-    "@cfpb/cfpb-notifications": "0.27.3",
-    "@cfpb/cfpb-pagination": "0.27.3",
-    "@cfpb/cfpb-tables": "0.27.3",
-    "@cfpb/cfpb-typography": "0.27.3",
+    "@cfpb/cfpb-atomic-component": "0.28.0",
+    "@cfpb/cfpb-buttons": "0.28.0",
+    "@cfpb/cfpb-core": "0.28.0",
+    "@cfpb/cfpb-expandables": "0.28.0",
+    "@cfpb/cfpb-forms": "0.28.0",
+    "@cfpb/cfpb-grid": "0.28.0",
+    "@cfpb/cfpb-icons": "0.28.0",
+    "@cfpb/cfpb-layout": "0.28.0",
+    "@cfpb/cfpb-notifications": "0.28.0",
+    "@cfpb/cfpb-pagination": "0.28.0",
+    "@cfpb/cfpb-tables": "0.28.0",
+    "@cfpb/cfpb-typography": "0.28.0",
     "@cfpb/rental-assistance-finder": "0.6.0",
     "@cypress/skip-test": "2.6.1",
     "autoprefixer": "10.4.14",
@@ -50,9 +50,9 @@
     "cypress": "12.17.3",
     "cypress-fail-fast": "7.0.1",
     "eslint": "8.46.0",
-    "eslint-config-prettier": "8.10.0",
+    "eslint-config-prettier": "9.0.0",
     "eslint-plugin-import": "2.28.0",
-    "eslint-plugin-jsdoc": "46.4.5",
+    "eslint-plugin-jsdoc": "46.4.6",
     "eslint-plugin-jsx-a11y": "6.7.1",
     "eslint-plugin-react": "7.33.1",
     "jest": "29.6.2",
@@ -62,9 +62,9 @@
     "postcss-less": "6.0.0",
     "prettier": "3.0.1",
     "snyk": "1.1200.0",
-    "stylelint": "14.16.1",
-    "stylelint-config-prettier": "9.0.5",
-    "stylelint-config-recommended-less": "1.0.4"
+    "stylelint": "15.10.2",
+    "stylelint-config-standard": "34.0.0",
+    "stylelint-less": "1.0.8"
   },
   "scripts": {
     "enforce": "enforce-node-version",