Include the table name in the with_x_translation

[louim]

When generating with_#{attr_name}_translation methods, include the table name in the query. This is to prevent a possible ambiguous column error when the model is joined with another model having the same translated column name.

For example:

class Post < ActiveRecord::Base
  has_many :tags
  translates :title, :body_1

  scope :tagged, -> (tag_title) { joins(:tags).merge(Tag.with_title_translation(tag_title)) }
end

class Tag < ActiveRecord::Base
  belongs_to :post
  translates :title
end

Calling Post.tagged("abc") would produce ActiveRecord::StatementInvalid: PG::AmbiguousColumn: ERROR: column reference "title_translations" is ambiguous because the table name was not included in the query. I added a test covering that case.

[frantisekrokusek]

I like it!

[frantisekrokusek]

Suggested change

	p = Post.create!(:title_translations => { "en" => "Alice in Wonderland", "fr" => "Alice au pays des merveilles" })
	Tag.create!(:title_translations => { "en" => "A Tag", "fr" => "Un tag" }, post: p)
	I18n.with_locale(:en) do
	assert_equal p.title_en, Post.tagged("A Tag").first.try(:title)
	post = Post.create!(:title_translations => { "en" => "Alice in Wonderland", "fr" => "Alice au pays des merveilles" })
	Tag.create!(:title_translations => { "en" => "A Tag", "fr" => "Un tag" }, post: post)
	I18n.with_locale(:en) do
	assert_equal post.title_en, Post.tagged("A Tag").first.title

[louim]

I'd be happy to make that change, but I originally went with p because that's what was used in all the tests. I think a change like that should be a separate PR and fix update all existing tests in one pass. What do you think?

[louim]

Hey @frantisekrokusek, I rebased this PR against the main branch. It seems like travis is not setup to run the tests anymore. Are you planning on switching to another CI tool setup?