Add order by for translated fields #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I like the idea. Can you please improve it as you proposed! ;) Ping me when it is ready for you! |
|
Any ETA on when this PR will be merged? |
frantisekrokusekpa
suggested changes
Aug 12, 2020
Comment on lines
+76
to
+84
| To order records using translations without constructing JSON queries by hand: | ||
|
|
||
| ```ruby | ||
| Post.order_by_title_translation # => #<ActiveRecord::Relation ...> | ||
| Post.order_by_title_translation(:asc) # => #<ActiveRecord::Relation ...> | ||
| Post.order_by_title_translation(:desc) # => #<ActiveRecord::Relation ...> | ||
| Post.order_by_title_translation(:desc, :he) # => #<ActiveRecord::Relation ...> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Can you please specify the defaults (direction and locale) in the README please?
| @@ -48,6 +48,16 @@ def translates(*attrs) | |||
| where("#{quoted_translation_store} @> :translation::jsonb", translation: translation_hash.to_json) | |||
| end | |||
| end | |||
|
|
|||
| define_singleton_method "order_by_#{attr_name}_translation" do |direction = :asc, locale = I18n.locale| | |||
There was a problem hiding this comment.
Why not "order_by_#{attr_name}#{SUFFIX}"? Would be more conventional.
End of August probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to review the quoting for the order by (currently it's hard-coded), there's probably a way to quote them properly using AR methods. However just checking would you be interested in accepting this functionality?