-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the option to includeAllKeys in trust-manager sources #1594
Document the option to includeAllKeys in trust-manager sources #1594
Conversation
9ac81bb
to
afc0d5b
Compare
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Julio Camarero <[email protected]>
Signed-off-by: Julio Camarero <[email protected]>
afc0d5b
to
320bd3f
Compare
Signed-off-by: Julio Camarero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thank you for this! I see no reason not to merge as I'll be releasing trust-manager soon with support for the includeAllKeys feature! 🚀
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
23b1b84
into
cert-manager:release-next
This PR adds documentation to the website regarding this trust-manager feature: cert-manager/trust-manager#460 (comment)
The first commit adds a new section for
sources
and the second one adds the information about the new feature.related to: cert-manager/trust-manager#458