Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update external issuers table #1578

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

terinjokes
Copy link
Contributor

The origin-ca-issuer has been supported and has had a tutorial since October 2020. A link to supported versions of Kubernetes and cert-manager as been added to satisfy the requirements here.

cfssl-issuer had release v0.4.0 tagged in August. tcs-issuer has not had a release since March 2023.

@cert-manager-prow cert-manager-prow bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2024
The origin-ca-issuer has been supported and has had a tutorial since
October 2020. A link to supported versions of Kubernetes and
cert-manager as been added to satisfy the requirements here.

cfssl-issuer had release v0.4.0 tagged in August. tcs-issuer has not had
a release since March 2023.

Signed-off-by: Terin Stock <[email protected]>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Oct 4, 2024
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bf52fec
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/66ff4d4004703500085b9912
😎 Deploy Preview https://deploy-preview-1578--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 36bdd37
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/66ff4d655160330008c8247c
😎 Deploy Preview https://deploy-preview-1578--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terinjokes

Thanks for maintaining the origin-ca-issuer.

As you say, the cfssl does seem to be more recently maintained,
and tcs issuers does seem to be unmaintained in the last 12 months.

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
@cert-manager-prow cert-manager-prow bot merged commit 45dddee into cert-manager:master Oct 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants