Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route53.role can be omitted when using IRSA #1487

Conversation

mamachanko
Copy link

It's the documentation cert-manager/cert-manager#4053 comment section is asking for.

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2024
Copy link

netlify bot commented May 29, 2024

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit c6e1c24
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6657128f56751d000842a91d
😎 Deploy Preview https://deploy-preview-1487--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have some suggestions and questions.

@@ -184,6 +184,8 @@ spec:

Note that, as mentioned above, the pod is using `arn:aws:iam::XXXXXXXXXXX:role/cert-manager` as a credentials source in Account X, but the `ClusterIssuer` ultimately assumes the `arn:aws:iam::YYYYYYYYYYYY:role/dns-manager` role to actually make changes in Route53 zones located in Account Y.

**Note:** If you are using IRSA, omit `route53.role`. See [#4053](https://github.com/cert-manager/cert-manager/issues/4053).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this note to the EKS IAM Role for Service Accounts (IRSA) (below).

And update the example ClusterIssuer config in that IRSA section:

I don't know much about AWS and IRSA....can you explain (in the documentation note) why the role does not need to be supplied in this case.

The documentation for the Go Web SDK suggests that RoleARN is required

I'm interested to understand this because I'm currently working on the following update to the Route53 solver code in cert-manager:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wallrj thank you for reviewing this! I must admit that - just like you - I don't know much about AWS and IRSA. The reason I opened this PR was the positive feedback on the comment demonstrating "the solution".

For now I reckon the best course of action is to close this PR, because I am afraid I am unable to back it up beyond said comment.

@wallrj
Copy link
Member

wallrj commented Oct 9, 2024

Supplanted by #1555

@wallrj wallrj closed this Oct 9, 2024
@mamachanko mamachanko deleted the topic/mamachanko/master/omit-role branch October 9, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants