Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release notes for 1.11.2->1.11.4 #1268

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Add release notes for 1.11.2->1.11.4 #1268

merged 1 commit into from
Aug 8, 2023

Conversation

swghosh
Copy link
Contributor

@swghosh swghosh commented Aug 7, 2023

Release notes for 1.11.2, 1.11.3, 1.11.4

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2023
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Aug 7, 2023
@swghosh
Copy link
Contributor Author

swghosh commented Aug 7, 2023

/cc @SgtCoDFish @irbekrm @inteon

SgtCoDFish
SgtCoDFish requested changes Aug 7, 2023
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks so much for this - this is an awesome PR to receive!

Our syntax parser is quite strict and is complaining about the <br> tags - I've added a suggestion for how to fix. Could you do that?

Thanks again!

content/docs/release-notes/release-notes-1.11.md Outdated Show resolved Hide resolved
@SgtCoDFish SgtCoDFish self-assigned this Aug 7, 2023
@swghosh
Copy link
Contributor Author

swghosh commented Aug 7, 2023

@SgtCoDFish I've updated it, PTAL.
Thanks very much for the review!

@netlify
Copy link

netlify bot commented Aug 7, 2023 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 9a57d8b
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/64d2161adf052f00081c0273
😎 Deploy Preview https://deploy-preview-1268--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swghosh swghosh mentioned this pull request Aug 7, 2023
Merged
1 task
@SgtCoDFish
Copy link
Member

Looks like there are a few spelling checker issues. I think most of them could be marked as code and that'd help it pass!

@swghosh
Copy link
Contributor Author

swghosh commented Aug 8, 2023

@SgtCoDFish fixed the spelling errors now.

» npm run check:spelling

> [email protected] check:spelling
> FORCE_COLOR=1 mdspell --report --en-us --ignore-numbers --ignore-acronyms 'content/**/*.md' 'content/**/*.html' '_layouts/*.html' '_includes/*.html' '*.html' '!**/api-docs.md' '!content/*docs/projects/approver-policy/api-reference.md' # Force color output in mdspell. # See https://github.com/lukeapage/node-markdown-spellcheck/issues/36#issuecomment-482649408

>> 1093 files are free from spelling errors

SgtCoDFish
SgtCoDFish approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Really appreciate this, thank you so much 😁 ❤️

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@jetstack-bot jetstack-bot merged commit 1ac66ed into cert-manager:master Aug 8, 2023
1 check passed
@jetstack-bot jetstack-bot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

@inteon inteon Awaiting requested review from inteon

@irbekrm irbekrm Awaiting requested review from irbekrm

Assignees

@SgtCoDFish SgtCoDFish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swghosh @SgtCoDFish @jetstack-bot