Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presubmit job for the org repo #1030

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Add presubmit job for the org repo #1030

merged 1 commit into from
Jun 11, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented May 27, 2024

Adds test job for logic added in cert-manager/org#1.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2024
@inteon inteon mentioned this pull request May 27, 2024
Open
@ThatsMrTalbot
Copy link
Contributor

/lgtm

@ThatsMrTalbot ThatsMrTalbot reopened this Jun 11, 2024
@ThatsMrTalbot
Copy link
Contributor

/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@ThatsMrTalbot
Copy link
Contributor

Sorry about closing it, missed the comment button 😅

@inteon
Copy link
Member Author

inteon commented Jun 11, 2024

/approve

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@cert-manager-prow cert-manager-prow bot merged commit 32ac783 into cert-manager:master Jun 11, 2024
6 checks passed
@cert-manager-prow
Copy link
Contributor

@inteon: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key org-presubmits.yaml using file config/jobs/cert-manager/org/org-presubmits.yaml

In response to this:

Adds test job for logic added in cert-manager/org#1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inteon @ThatsMrTalbot