-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OLM deployment #1
Conversation
Signed-off-by: Maartje Eyskens <[email protected]>
/hold need to fix the version numbers |
Signed-off-by: Maartje Eyskens <[email protected]>
Signed-off-by: Maartje Eyskens <[email protected]>
Signed-off-by: Maartje Eyskens <[email protected]>
Signed-off-by: Maartje Eyskens <[email protected]>
Signed-off-by: Maartje Eyskens <[email protected]>
Signed-off-by: Maartje Eyskens <[email protected]>
/unhold |
/assign @munnerz |
alm-examples: ' [{"apiVersion":"operator.cert-manager.io/v1alpha1","kind":"CertManager","metadata":{"name":"cert-manager","namespace":"cert-manager"},"spec":{}}]' | ||
capabilities: Full Lifecycle | ||
categories: Security | ||
certified: 'false' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably we flip this somewhere further down the line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should, for now it isn't fully certified yet
...ger-operator/0.15.0-alpha.0/cert-manager-operator.v0.15.0-alpha.0.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
resources: | ||
- '*' | ||
verbs: | ||
- '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really should look to reduce this at some point.. for now though LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed #3
maintainers: | ||
- email: [email protected] | ||
name: cert-manager team | ||
maturity: alpha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does maturity here refer to? When does this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should refer to the application release, which for now is Alpha
Signed-off-by: Maartje Eyskens <[email protected]>
@munnerz ready for re-review |
Signed-off-by: Maartje Eyskens <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: meyskens, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Moving the OLM deployment into it's own separate repository