Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OLM deployment #1

Merged
merged 9 commits into from
Apr 22, 2020
Merged

Add OLM deployment #1

merged 9 commits into from
Apr 22, 2020

Conversation

meyskens
Copy link
Contributor

Moving the OLM deployment into it's own separate repository

Signed-off-by: Maartje Eyskens <[email protected]>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Apr 17, 2020
@jetstack-bot jetstack-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 17, 2020
@meyskens
Copy link
Contributor Author

/hold

need to fix the version numbers

@jetstack-bot jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Apr 17, 2020
Signed-off-by: Maartje Eyskens <[email protected]>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Apr 17, 2020
Signed-off-by: Maartje Eyskens <[email protected]>
Signed-off-by: Maartje Eyskens <[email protected]>
Signed-off-by: Maartje Eyskens <[email protected]>
Signed-off-by: Maartje Eyskens <[email protected]>
Signed-off-by: Maartje Eyskens <[email protected]>
@meyskens
Copy link
Contributor Author

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2020
@meyskens
Copy link
Contributor Author

/assign @munnerz

README.md Outdated Show resolved Hide resolved
alm-examples: ' [{"apiVersion":"operator.cert-manager.io/v1alpha1","kind":"CertManager","metadata":{"name":"cert-manager","namespace":"cert-manager"},"spec":{}}]'
capabilities: Full Lifecycle
categories: Security
certified: 'false'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably we flip this somewhere further down the line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should, for now it isn't fully certified yet

resources:
- '*'
verbs:
- '*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should look to reduce this at some point.. for now though LGTM :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed #3

maintainers:
- email: [email protected]
name: cert-manager team
maturity: alpha
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does maturity here refer to? When does this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should refer to the application release, which for now is Alpha

Signed-off-by: Maartje Eyskens <[email protected]>
@meyskens
Copy link
Contributor Author

@munnerz ready for re-review

Signed-off-by: Maartje Eyskens <[email protected]>
@munnerz
Copy link
Member

munnerz commented Apr 22, 2020

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: meyskens, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020
@jetstack-bot jetstack-bot merged commit 9d95530 into cert-manager:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants