Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restricting default railties version to be < 7 #1416

Closed
wants to merge 1 commit into from
Closed

restricting default railties version to be < 7 #1416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ when 'master'
gem 'railties', { git: 'https://github.com/rails/rails.git' }
gem 'arel', { git: 'https://github.com/rails/arel.git' }
when 'default'
gem 'railties', '>= 6.0'
gem 'railties', '>= 6.0', '< 7'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the Gemfile this would be a development level concern. what you're intention which stopping development testing against Rails 7 but not stopping releases from using it?

Also, since you're targeting master/main, which release are you on?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now master doesn't seem compatible w/ Rails 7; as I noted in the issue, when you check out the repository but don't specify rails version, it will pick up latest (7.x at present), and tests will fail. I opened this as it threw me for a loop when trying to get started on development w/ this project.

Copy link
Collaborator

@bf4 bf4 Oct 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now master doesn't seem compatible w/ Rails 7;

why are you targeting master, though? If you're interesting in beginning with development, you should start with branch v0-11-dev (which is known to be failing on Rails 7.1 right now)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I first came to this project I had no way of knowing that active development wasn't off of master, I simply followed the 'contributing' directions in the README.

Copy link
Collaborator

@bf4 bf4 Oct 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem. Usually that's true. Just not at this precise moment. Thanks for getting involved!

else
gem 'railties', "~> #{version}"
end