report, lock.ops, lock.query: add retry mechanism to paddles requests #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need requests to paddles to retry multiple times in case of 500 errors from the DB server. This change adds a retry mechanism to the paddles requests that previously did not have one. Fixes: https://tracker.ceph.com/issues/50921 Signed-off-by: Aishwarya Mathuria <[email protected]>
amathuria
force-pushed
the
wip-add-retry-paddles
branch
from
d86973f
to
aaeddfd
Compare
|
kshtsk
reviewed
Jul 7, 2021
| elif reimage and machine_type in reimage_types: | ||
| return reimage_machines(ctx, machines, machine_type) | ||
| return machines | ||
| elif response.status_code == 503: |
There was a problem hiding this comment.
Do I understand correctly that it is trying to retry on any error, not only 500?
There was a problem hiding this comment.
Yes, that is correct.
|
there are conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need requests to paddles to retry multiple times in case of 500
errors from the DB server. This change adds a retry mechanism to the
paddles requests that previously did not have one.
Fixes: https://tracker.ceph.com/issues/50921
Signed-off-by: Aishwarya Mathuria [email protected]