Fix macOS and Linux build #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oops :| |
|
lgtm, thanks :) |
vivia
reviewed
Oct 31, 2024
| @@ -84,10 +84,14 @@ set(GSTCEF_SRCS | |||
| ) | |||
There was a problem hiding this comment.
Just one line above there's another gstcefloader.cc
vivia
reviewed
Oct 31, 2024
| @@ -141,7 +140,7 @@ int main(int argc, char * argv[]) | |||
| CefMainArgs args(argc, argv); | |||
| #endif | |||
|
|
|||
| #ifdef GST_CEF_USE_SANDBOX | |||
| #if defined(__APPLE__) && defined(GST_CEF_USE_SANDBOX) | |||
There was a problem hiding this comment.
The same change has to be made also in gstcef.cc in two places
amyspark
added a commit
to amyspark/gstcefsrc
that referenced
this pull request
Nov 1, 2024
MathieuDuponchelle
pushed a commit
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This PR fixes two issues I was made aware of today: