Mon-106121 move centreon perl libs packages #1832

Evan-Adam · 2024-11-05T16:05:30Z

Description

This PR aim to move the centreon-perl-libs package from centreon repo to centreon-collect repo.
Some of the reason :

avoid a cyclyc dependancy, so when creating a new major version build collect first (which don't have dependancy on web) then build web (which have dependancy on collect)
gorgone need the new centreon-perl-libs-common package (for centreonvault)

Fixes # MON-106121

Type of change

Patch fixing an issue (non-breaking change)
New functionality (non-breaking change)
Breaking change (patch or feature) that might cause side effects breaking part of the Software
Updating documentation (missing information, typo...)

Target serie

How this pull request can be tested ?

Build web + collect, everything should be installed correctly.

Checklist

I have followed the coding style guidelines provided by Centreon
I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
I have commented my code, especially hard-to-understand areas of the PR.
I have made corresponding changes to the documentation.
I have rebased my development branch on the base branch (master, maintenance).

…are with cli commands)

Conflicts: lib/perl/centreon/centstorage/CentstorageRRD.pm

Refs: MON-10739

* remove log_archive_path, log_rotation_method, daemon_dumps_core, move debug config section in log options tab * add logger v2 form * fix form * update cfg_nagios table, create cfg_angios_logger table in DB * fix sql table creation * fix install default logger config * get logger info in form, fix jquery form display * modify cfg_nagios tables * fix default values of new logger for install/upgrade * fix default values of new logger for install/upgrade * handle config creation with logger V2 * update default values for logger v2 * handle update with logger V2 * remove helptooltips * fix typo * fix form, logger update, handle conf export * fix logger update * handle logger v2 * update clapi export file for tests * update scripts to get archives_path from log_file_path * add form translation * fix code style * Apply suggestion * Apply suggestions from code review Co-authored-by: Kevin Duret <[email protected]> * add translation lines on po files * Apply suggestions * move create table to sql update file * Update www/install/createTables.sql Co-authored-by: Laurent Calvet <[email protected]> * Remove duplicate comments * Change log_level_external_commands default level * Apply suggestions from code review * create loggerV2Cfg in DB when creating/duplicating poller, duplicating engineCfg * update form to display log enable/disable options * export old log options * Apply suggestions from code review (docblock) Co-authored-by: Kevin Duret <[email protected]> * Fix form display, remove useless translation * Apply suggestions from code review Co-authored-by: Kevin Duret <[email protected]> * bind request values * fix translation * Update www/include/configuration/configNagios/DB-Func.php Co-authored-by: Laurent Calvet <[email protected]> * fix code style Co-authored-by: Kevin Duret <[email protected]> Co-authored-by: Laurent Calvet <[email protected]>

… (#11706)

…olkit (#4987)

…one/centreon_vmware Refs:MON-106121

* add new log level to be used by clients * add getter/setter for new option withdate and fix withpid * simplify writeLog sub Refs:MON-106121

* Add a readme file * Add a github workflow to run all tests on every changes. This workflow use centreon-plugin docker image. Refs:MON-106121

Refs:MON-106121

* this library was initialy started in centreon-plugin repository, but need to be used by centreon_vmware and gorgone, so it should be in a common package. Change since centreon-plugins: * update error message to be less alarming for the user. * app_secret can be retrieved from .env file if env variable is not set. * remove error log when vault is not enabled. As vault is optionnal if it is not configured it should be warning at most. Refs:MON-106121

…parameter-to-get-vault-credentials' into MON-106121-move-centreon-perl-libs-packages

coderabbitai · 2024-11-05T16:05:37Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Quentin Garnier and others added 30 commits November 25, 2013 14:03

+ Fix an output for snmp traffic standard

1c4147c

+ Add adminstatus in interface list

224c6bb

+ Add mode standard 'spanning-tree' mode

343238e

+ Fix round number

674f647

+ Add windows mode for 'service'

d7a0149

+ Add plugin netapp :)

b311d70

+ Add mode 'partnerstatus' for netapp

7ba7220

fixes #4972; escape single quotes

90e8ae2

change header for perl files.

61be0ae

+ Add Juniper SRX monitoring plugin

a1ae97f

+ better output for some plugins

57426cf

+ Minor fix issue in options

2dc6d81

+ Begin working on migrate of snmpconvertmib

1405855

+ trap snmpconvertmib: Begin to work

3e9dfa4

Fix #4661

a053e32

+ Add mode for listing storages

b6944b7

+ Add Cisco ASA plugin and liststorages mode

28d9ac1

+ Add a system to create 'custom' mode (permits to monitor some hardw…

0916745

…are with cli commands)

Begin to work on 'numericvalue' mode

9e1ed6d

+ Add mode to check numeric value in SNMP (2 more coming soon)

eaf35c2

+ Add mode to compare string, integer in SNMP

6f91ecf

+ Understanding dynamic command. Can work on it now.

fec35c7

+ working on new mode snmp

cde591a

+ Add SNMP mode to execute dynamic command

4fa3e33

+ plugins moved in dedicated repo

4a62c82

* Refs #4940 : Change metric name in rrd file in CentStorage

189df7b

Fix #4940

4c5b026

remove centstorage... bye bye !

3fbc9c3

Merge branch 'master' of https://github.com/julienmathis/centreon

2e6ba70

Conflicts: lib/perl/centreon/centstorage/CentstorageRRD.pm

fix #5099

60a3b72

garnier-quentin and others added 29 commits October 29, 2020 11:18

fix(perl/libs): database query bad looping parameters (#9059)

f100e3a

MON-6280: Add a special variable for trap OID (#9182)

53f6383

fix(sql): fix compatibility with MySQL 8 (#10034)

f7a301a

Refs: MON-10739

fix(export): fix conf export fail because of centreontrapd (#9973)

a3f765b

fetch and rebase (#235)

206e753

Merge branch 'centreon:develop' into develop

8f819a6

fix(perlcore): test conf.pm file present (#10913)

73a86bb

fix(centreontrapd): check if conf file is not empty before to load it…

ea533bd

… (#11706)

chore(git): synchronize centreon web develop branch (#43)

e49f566

merge centreon-dsm

1ffbe04

fix(centreontrapd): carriage return entreprise args

665bd1a

Centreon 23.10 (Jira release #19426#)

ec61bf6

MON-22657 Sync Centreon OSS next 23.10 (#2482)

8e65ca8

Sync dev-23.10.x vers develop oss (#2487)

aaf0f61

enh(packaging): package centreon web using nfpm (#2673)

8b80452

Centreon 24.04 (Jira release #19608#)

ecfe7be

Empty-Commit

5bad36b

MON-34022 Sync Centreon OSS next 24.04 (Jira release #34022#) (#3181)

97a58d6

Centreon 24.04 (Jira release #19735#)

a939107

MON-37060 Sync Centreon OSS next 24.04 (Jira release #37060#) (#3826)

91427f3

feat(ci): install centreon web on container startup and remove slimto…

69c16cb

…olkit (#4987)

ci(perl-libs): move common libs in another package to be used by gorg…

d91e06b

…one/centreon_vmware Refs:MON-106121

feat(perl-logger): merge and enhance logger library.

f7a86df

* add new log level to be used by clients * add getter/setter for new option withdate and fix withpid * simplify writeLog sub Refs:MON-106121

test(perl-logger): Add unit tests and run them on the CI

4528304

* Add a readme file * Add a github workflow to run all tests on every changes. This workflow use centreon-plugin docker image. Refs:MON-106121

tests(centreonvault): remove pid on verbose and add more tests.

578d889

Refs:MON-106121

ci(perl): move centreon-perl-libs to centreon-collect repository

04a5127

Merge remote-tracking branch 'repo-A/MON-106121-pull-wss-add-gorgone-…

e826da7

…parameter-to-get-vault-credentials' into MON-106121-move-centreon-perl-libs-packages

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mon-106121 move centreon perl libs packages #1832

Mon-106121 move centreon perl libs packages #1832

Evan-Adam commented Nov 5, 2024

coderabbitai bot commented Nov 5, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Mon-106121 move centreon perl libs packages #1832

Are you sure you want to change the base?

Mon-106121 move centreon perl libs packages #1832

Conversation

Evan-Adam commented Nov 5, 2024

Description

Type of change

Target serie

How this pull request can be tested ?

Checklist

coderabbitai bot commented Nov 5, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

CodeRabbit Configuration File (`.coderabbit.yaml`)