776 bug in mod book chapter viewed

[ScottVerbeek]

Description

• The \mod_book\event\chapter_viewed event for module mod_book was fetching a parent chapter incorrectly. Before subchapter was used as a ID, which is actually a boolean value. Here is a representation of what it should look like, and should help understand the code. Also the upstream merge request is here: correctly fetch a subchapters parent (#776) & refactor TestRepository::read_records() method xAPI-vle/moodle-logstore_xapi#849

 SELECT id, bookid, pagenum, subchapter, title FROM mdl_book_chapters ORDER BY pagenum;                  
 id | bookid | pagenum | subchapter |         title         
----+--------+---------+------------+-----------------------
  1 |      1 |       1 |          0 | Chapter 1
  2 |      1 |       2 |          1 | Chapter 1.1
  3 |      1 |       3 |          1 | Chapter 1.2
  4 |      1 |       4 |          1 | Chapter 1.3
  6 |      1 |       5 |          1 | Chapter 1.4 (was 2.1)
  5 |      1 |       6 |          0 | Chapter 2
(6 rows)

Related Issues

• Bug in events related to subchapters xAPI-vle/moodle-logstore_xapi#776
• TestRepository::read_records() array $query with more than one condition returns duplicate and mismatching records xAPI-vle/moodle-logstore_xapi#850

PR Type

• Fix and improvements

[ScottVerbeek]

Reduced the scope of this to only target the mod_chapter problem. The other issues on upstream seem to already be resolved on this fork and contain changes for compatibility.