Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attack Tree render code #125

Merged
merged 12 commits into from
Jun 28, 2024
Merged

Attack Tree render code #125

merged 12 commits into from
Jun 28, 2024

Conversation

allisonrobbins
Copy link
Contributor

Add ability to visualize/build/render Attack Trees using existing Attack Flow infastructure

  • Add attack tree option to scope dropdown
  • Redirect render code based on the scope value
  • Render attack trees based on specifications
  • Condense operator/action node combination down into one node

@allisonrobbins allisonrobbins marked this pull request as ready for review June 19, 2024 18:49
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 82.19178% with 26 lines in your changes missing coverage. Please review.

Project coverage is 97.03%. Comparing base (fa725e0) to head (0cd1062).
Report is 3 commits behind head on main.

Current head 0cd1062 differs from pull request most recent head 8571e32

Please upload reports for the commit 8571e32 to get more accurate results.

Files Patch % Lines
src/attack_flow/graphviz.py 85.07% 10 Missing ⚠️
src/attack_flow/mermaid.py 85.50% 10 Missing ⚠️
src/attack_flow/cli.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   99.64%   97.03%   -2.61%     
==========================================
  Files           9        9              
  Lines         837      978     +141     
==========================================
+ Hits          834      949     +115     
- Misses          3       29      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mehaase mehaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @mikecarenzo do you want a chance to review this or should we merge?

@mikecarenzo
Copy link
Contributor

mikecarenzo commented Jun 28, 2024

@mehaase I've already reviewed a large portion of the code. Now that all the test cases are in, I'll give it one last review before merging.

@mikecarenzo mikecarenzo merged commit 47bcd71 into main Jun 28, 2024
@mikecarenzo mikecarenzo deleted the attack-tree branch June 28, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants