Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 to v4 update script #209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

v3 to v4 update script #209

wants to merge 2 commits into from

Conversation

pahor167
Copy link
Contributor

@pahor167 pahor167 commented Oct 23, 2024

Description

A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

@pahor167 pahor167 enabled auto-merge (squash) November 6, 2024 11:51
import {
MULTISIG_ENCODE_PROPOSAL_PAYLOAD,
MULTISIG_SUBMIT_PROPOSAL,
MULTISIG_UPDATE_V2_V3,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be V3_V4?

await generateContractUpdate(hre, "Manager", destinations, values, payloads);
await generateContractUpdate(hre, "SpecificGroupStrategy", destinations, values, payloads);
await generateContractUpdate(hre, "DefaultStrategy", destinations, values, payloads);
await generateContractUpdate(hre, "Account", destinations, values, payloads);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should'nt the Vote contract be included as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants