Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initializeAnchorStateRegistry config. Update Fault Proof config #260

Closed

Conversation

jcortejoso
Copy link
Member

Added a new config flag initializeAnchorStateRegistry to skip the initialization of AnchorStateRegistry in the execution of Deploy.s.sol. This, can be initialized latter when the faultGameGenesisOutputRoot is known.

Also updated the config template in config-vars-celo.sh to match OP Mainnet and Sepolia FaultProof config.

@piersy
Copy link

piersy commented Oct 16, 2024

Hey @jcortejoso, what I'm not understanding here is how was this working for optimism? Because you need to have done the l1 deployments in order to generate the l2 genesis allocs, and here in order to call initializeAnchorStateRegistry you need to have the l2 genesis. So it seems like it could never have worked for them?

@jcortejoso jcortejoso marked this pull request as draft October 16, 2024 10:55
@jcortejoso
Copy link
Member Author

@piersy my understanding is that OP deployment has been different from us, and they introduced Fault Proofs in a posterior upgrade, so they can init the state to an arbitrary existing block:

This is initialized with the starting anchor for CANNON and PERMISSIONED_CANNON games set to block number 120059863 and output root 0x2694ac14dcf54b7a77363e3f60e6462dc78da0d43d1e2f058dbb6a1488814977.

I wonder for a migrated network in our case we could use a pre-migration block as anchor for the deployment. My concern if that can be risky because op-proposer may require archive data afaik.

Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 31, 2024
@github-actions github-actions bot closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants