Karlb/celo10 2 #256
Closed
Karlb/celo10 2 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## karlb/celo10-upstream #256 +/- ##
=========================================================
+ Coverage 68.11% 68.30% +0.19%
=========================================================
Files 54 54
Lines 4118 4118
=========================================================
+ Hits 2805 2813 +8
+ Misses 1135 1126 -9
- Partials 178 179 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
karlb
force-pushed
the
karlb/celo10-2
branch
4 times, most recently
from
3af7531
to
0d86137
Compare
Adding funding.json file required to apply for retropgf
- Remove unnecessary jobs
Setting `open-pull-requests-limit: 0` prevent version updates but should keep the security scans and updates according to https://docs.github.com/en/code-security/dependabot/dependabot-security-updates/configuring-dependabot-security-updates#overriding-the-default-behavior-with-a-configuration-file > If you only require security updates and want to exclude version > updates, you can set open-pull-requests-limit to 0 in order to prevent > version updates for a given package-ecosystem.
* adding trivy scanning to the Docker files * adding docker build scan * fixing typo * adding context for bedrock images * adding context to ops dockerfile packages * fixing context for ops packges: * removing push/pull triggers and adding just a manual workflow run with workflow_dispatch
As far as I understand, all gas values are for the L1 transaction that submits the tx batches. Therefore, the fee currency can be set to `nil`.
* Add pages workflow and forkdiff config * Remove TODOs * Update trigger to reflect future celo default branch pattern * Update latest rebased commit
Remove common/interfaces/IExchange.sol (duplicate) We keep the one in the `mento` directory. Remove common/libraries/ReentrancyGuard.sol (duplicate) Directly use the original from OpenZeppelin.
This allows testing of newly deployed fee currencies even when MockSortedOracles is used. This is the some implementation used in celo-monorepo (except for updating it to a more recent solidity version).
so that BridgedETH and other bridged ERC20 tokens can be used as fee currencies. I won't included testing until the FeeCurrencyDirectory is ready.
Until we fix the errors caused by enabling it.
We need to include Celo's contracts in the count to make it succeed.
Change base fee calculation for transition block Previously we used the parent base fee, now we use the eip1559 calculation to calculate the base fee for the transition block. Also updated the referenced op-geth that includes an updated CalcBaseFee function. The approach was changed to remove reliance on IsCel2 inside CalcBaseFee which helps to avoid unexpected consequences when working with tests that do or don't set the cel2 fork Co-authored-by: Piers Powlesland <[email protected]>
Make migration-block-time a required flag --------- Co-authored-by: alecps <[email protected]> Co-authored-by: piersy <[email protected]>
EigenDA current limit for Holesky (their documentation is currently outdated but the limit seems to be set to 16 MB based on the updated tests from [this PR](Layr-Labs/eigenda-proxy#100)).
Those have warnings with `check-interfaces.sh`. Ignore those warnings for now.
This cheatcode is used to store the Celo L2 predeploy addresses in a JSON file when run with forge. Inside TestEndToEndApply/initial_chain , the same code is called but we don't care for the generated JSON file. So just returning `nil` makes the test work without any disadvantages.
Changes in implementation require changes in version. This is ensured by `./scripts/checks/check-semver-diff.sh`.
…254) * OptimismPortal2 set initial `_balance` through StorageSetter pattern Fixes #239 The custom gas-token feature adaptation for the fault-proof system using the `OptimismPortal2` contract has been merged recently upstream. We are using the custom-gas-token feature and additionally require a modification of the OptimismPortal's `_balance` value to be set to the entire allocation of Celo on the L2 - meaning that all L1 token is initially locked in the bridge and only usable on the L2. Those changes are now adapted also to the `OptimismPortal2`, which was a requirement to make our custom-gas-token pre-locked balance feature work in conjunction with fault-proofs. * Adapt withdraw e2e-tests to work with fault-proofs * Use prettier for formatting e2e tests * Fix typo Co-authored-by: Valentin Rodygin <[email protected]> * Set L1-fee scalars to zero in devnet --------- Co-authored-by: Valentin Rodygin <[email protected]>
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.