Skip to content

Commit

Permalink
op-e2e: Don't override the sequencer window in tests where it shouldn…
Browse files Browse the repository at this point in the history
…'t be needed. (ethereum-optimism#12502)

Use a longer window in the one test it may affect - 16 does get hit unexpectedly in CI.
  • Loading branch information
ajsutton authored Oct 17, 2024
1 parent c26ab41 commit 94204e9
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
3 changes: 0 additions & 3 deletions op-e2e/faultproofs/cannon_benchmark_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ func testBenchmarkCannonFPP(t *testing.T, allocType config.AllocType) {
cfg := e2esys.DefaultSystemConfig(t, e2esys.WithAllocType(allocType))
// We don't need a verifier - just the sequencer is enough
delete(cfg.Nodes, "verifier")
// Use a small sequencer window size to avoid test timeout while waiting for empty blocks
// But not too small to ensure that our claim and subsequent state change is published
cfg.DeployConfig.SequencerWindowSize = 16
minTs := hexutil.Uint64(0)
cfg.DeployConfig.L2GenesisDeltaTimeOffset = &minTs
cfg.DeployConfig.L2GenesisEcotoneTimeOffset = &minTs
Expand Down
6 changes: 0 additions & 6 deletions op-e2e/faultproofs/precompile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ func testPrecompiles(t *testing.T, allocType e2e_config.AllocType) {
cfg.AllocType = allocType
// We don't need a verifier - just the sequencer is enough
delete(cfg.Nodes, "verifier")
// Use a small sequencer window size to avoid test timeout while waiting for empty blocks
// But not too small to ensure that our claim and subsequent state change is published
cfg.DeployConfig.SequencerWindowSize = 16

sys, err := cfg.Start(t)
require.Nil(t, err, "Error starting up system")
Expand Down Expand Up @@ -199,9 +196,6 @@ func testGranitePrecompiles(t *testing.T, allocType e2e_config.AllocType) {
cfg.AllocType = allocType
// We don't need a verifier - just the sequencer is enough
delete(cfg.Nodes, "verifier")
// Use a small sequencer window size to avoid test timeout while waiting for empty blocks
// But not too small to ensure that our claim and subsequent state change is published
cfg.DeployConfig.SequencerWindowSize = 16

sys, err := cfg.Start(t)
require.Nil(t, err, "Error starting up system")
Expand Down
2 changes: 1 addition & 1 deletion op-e2e/system/proofs/system_fpp_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func testVerifyL2OutputRootEmptyBlock(t *testing.T, detached bool, spanBatchActi
delete(cfg.Nodes, "verifier")
// Use a small sequencer window size to avoid test timeout while waiting for empty blocks
// But not too small to ensure that our claim and subsequent state change is published
cfg.DeployConfig.SequencerWindowSize = 16
cfg.DeployConfig.SequencerWindowSize = 30
applySpanBatchActivation(spanBatchActivated, cfg.DeployConfig)

sys, err := cfg.Start(t)
Expand Down

0 comments on commit 94204e9

Please sign in to comment.