Soloseng/fix-precompile-inheritance #11310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…soloseng/L2-FeeCurrencyDirectory-test
Soloseng/fix-precompile-inheritance
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
…soloseng/L2-FeeCurrencyDirectory-test
…x-precompile-inheritance
soloseng
changed the base branch from
soloseng/L2-FeeCurrencyDirectory-test
to
release/core-contracts/12
martinvol
reviewed
Jan 23, 2025
packages/protocol/contracts-0.8/common/PrecompilesOverrideV2.sol
Outdated
Show resolved
Hide resolved
martinvol
reviewed
Jan 23, 2025
martinvol
reviewed
Jan 23, 2025
martinvol
reviewed
Jan 23, 2025
martinvol
reviewed
Jan 23, 2025
…soloseng/fix-precompile-inheritance
martinvol
approved these changes
Jan 24, 2025
martinvol
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed precompile inheritance issue to allow tests in solidity 0.8 to compile without conflict.
Other changes
Deprecated the use of
celo-foundrytest in the contract causing issues. The aim is to eventually move away from usingcelo-foundryand have the functions we use in the utils contract.Tested
unit tested with original test