Add sts_token_buffer_time parameter to transport options #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eisichenko
force-pushed
the
feature/sts-token-generate-buffer-time
branch
7 times, most recently
from
b45c6c8 to
54ac9db
Compare
eisichenko
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2216 +/- ##
=======================================
Coverage 81.50% 81.51%
=======================================
Files 77 77
Lines 9524 9529 +5
Branches 1152 1153 +1
=======================================
+ Hits 7763 7768 +5
Misses 1569 1569
Partials 192 192 ☔ View full report in Codecov by Sentry. |
eisichenko
force-pushed
the
feature/sts-token-generate-buffer-time
branch
from
54ac9db to
488993c
Compare
…date token earlier than expiration time
eisichenko
force-pushed
the
feature/sts-token-generate-buffer-time
branch
from
488993c to
e00da33
Compare
|
I started the CI. So lets see |
@auvipy all checks are passed |
auvipy
requested changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue: #2217
During development, I've encountered an issue where Kombu does not currently provide an option to generate an STS token before its expiration time. This can lead to errors such as:
Request HTTP Error HTTP 403 Forbidden (b'{"__type":"com.amazon.coral.service#ExpiredTokenException","message":"The security token included in the request is expired"}')Such errors occur when the session token expires, which can cause the consumer channel to close when working with Celery.
This PR introduces a new optional parameter
sts_token_buffer_timewhich defaults to0, preserving the previous behavior. When provided, this attribute allows the STS token to be generated earlier by the specified buffer time seconds (sts_token_buffer_time), helping to prevent ExpiredTokenException errors.