Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Pr2226 analyst report email subject missing french #2277

Merged
merged 5 commits into from
Sep 14, 2020

Conversation

dengcn
Copy link
Contributor

@dengcn dengcn commented Sep 10, 2020

Fixes #2226

Description

French missing in Subject of Analyst Email

Please include a summary of the change.
In the Email hanlding utility

Any new packages installed?

No

Give details

Required followup work

Is there anything related to this that still needs to be done (ex: documentation changes).

Checklist:

  • I have updated the azurescript.sh with any new environment variables and added them to the appsettings
  • [ X] I have looked at my code on GitHub and it all looks good (ex: no random commented out code or console.logs)
  • I have added and needed tests for my changes (in particular for new screens)
  • I have added a comment to any confusing code
  • I have added documentation to any modified front-end code. (Or added missing documentation)

@sastels sastels temporarily deployed to rac-prototyp-pr2226emai-vq7ssi September 10, 2020 18:38 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Sep 10, 2020

This pull request introduces 6 alerts when merging 2584bb8 into 0f45890 - view on LGTM.com

new alerts:

  • 3 for Implicit operand conversion
  • 3 for Use of returnless function

@sastels sastels temporarily deployed to rac-prototyp-pr2226emai-vq7ssi September 10, 2020 19:02 Inactive
@dengcn
Copy link
Contributor Author

dengcn commented Sep 11, 2020

Here is the screen shot at RCMP Email (Analyst) will see in subject
In case such helf harm is captured, and reporter use French, the subject in received RCMP email subject title will be like this

image

@sastels sastels temporarily deployed to rac-prototyp-pr2226emai-vq7ssi September 14, 2020 19:01 Inactive
@dengcn dengcn merged commit f1f16c8 into master Sep 14, 2020
@dengcn dengcn deleted the pr2226EmailSubjectMissingFrench branch September 14, 2020 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning message in Subject of analyst email should be French as well for french report
3 participants