Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just do 5000 sized bulk sends in test #2424

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Jan 22, 2025

Summary | Résumé

Just do a bulk send of 5000 every 30 seconds.

Test related to an incident.

Test instructions | Instructions pour tester la modification

locust -f ./load_test.py

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Comment on lines +59 to +61
# def send_high_priority_sms(self):
# json = {"phone_number": self.phone_number, "template_id": self.high_priority_sms_template}
# self.client.post("/v2/notifications/sms", json=json, headers=self.headers)

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +64 to +65
# def send_medium_priority_sms(self):
# self.send_bulk_sms(self.medium_priority_sms_template, 199)

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +68 to +71
# def send_low_priority_sms(self):
# self.send_bulk_sms(self.low_priority_sms_template, 1000)

# Email Tasks
# # Email Tasks

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +74 to +76
# def send_high_priority_email(self):
# json = {"email_address": self.email_address, "template_id": self.high_priority_email_template}
# self.client.post("/v2/notifications/email", json=json, headers=self.headers)

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +79 to +80
# def send_medium_priority_email(self):
# self.send_bulk_email(self.medium_priority_email_template, 199)

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +89 to +90
# def do_nothing(self):
# pass

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@sastels sastels changed the title just do bulk sends just do 5000 sized bulk sends in test Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant