generated from cds-snc/project-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): lock file maintenance #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Production: glue 🧴✅ Terraform Init: Plan: 0 to add, 1 to change, 0 to destroy Show summary
Show planResource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_glue_crawler.operations_aws_production_account_tags will be updated in-place
~ resource "aws_glue_crawler" "operations_aws_production_account_tags" {
~ classifiers = [
- "JSON array",
]
id = "Organization Account Tags"
name = "Organization Account Tags"
tags = {}
# (9 unchanged attributes hidden)
# (5 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Show Conftest resultsWARN - plan.json - main - Missing Common Tags: ["aws_glue_catalog_database.operations_aws_production"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_crawler.operations_aws_production_account_tags"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_crawler.operations_aws_production_cost_usage_report"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.glue_crawler"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.glue_crawler"]
WARN - plan.json - main - Missing Common Tags: ["aws_kms_key.aws_glue"]
25 tests, 19 passed, 6 warnings, 0 failures, 0 exceptions
|
Production: alarms 🚨✅ Terraform Init: Plan: 10 to add, 0 to change, 0 to destroy Show summary
Show planResource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# aws_cloudwatch_log_metric_filter.glue_crawler_error will be created
+ resource "aws_cloudwatch_log_metric_filter" "glue_crawler_error" {
+ id = (known after apply)
+ log_group_name = "mock-glue-crawler-log-group"
+ name = "glue-crawler-error"
+ pattern = "ERROR"
+ metric_transformation {
+ default_value = "0"
+ name = "glue-crawler-error"
+ namespace = "data-lake"
+ unit = "Count"
+ value = "1"
}
}
# aws_cloudwatch_metric_alarm.glue_crawler_error will be created
+ resource "aws_cloudwatch_metric_alarm" "glue_crawler_error" {
+ actions_enabled = true
+ alarm_actions = (known after apply)
+ alarm_description = "Errors logged over 1 minute by the Glue Crawler."
+ alarm_name = "glue-crawler-error"
+ arn = (known after apply)
+ comparison_operator = "GreaterThanThreshold"
+ evaluate_low_sample_count_percentiles = (known after apply)
+ evaluation_periods = 1
+ id = (known after apply)
+ metric_name = "glue-crawler-error"
+ namespace = "data-lake"
+ ok_actions = (known after apply)
+ period = 60
+ statistic = "Sum"
+ tags_all = {
+ "CostCentre" = "PlatformDataLake"
+ "Terraform" = "true"
}
+ threshold = 0
+ treat_missing_data = "notBreaching"
}
# aws_cloudwatch_query_definition.glue_crawler_errors will be created
+ resource "aws_cloudwatch_query_definition" "glue_crawler_errors" {
+ id = (known after apply)
+ log_group_names = [
+ "mock-glue-crawler-log-group",
]
+ name = "Glue Crawler - ERRORS"
+ query_definition_id = (known after apply)
+ query_string = <<-EOT
fields @timestamp, @message, @logStream
| filter @message like /ERROR/
| sort @timestamp desc
| limit 100
EOT
}
# aws_kms_key.cloudwatch will be created
+ resource "aws_kms_key" "cloudwatch" {
+ arn = (known after apply)
+ bypass_policy_lockout_safety_check = false
+ customer_master_key_spec = "SYMMETRIC_DEFAULT"
+ description = "SNS topic for CloudWatch alarm actions"
+ enable_key_rotation = true
+ id = (known after apply)
+ is_enabled = true
+ key_id = (known after apply)
+ key_usage = "ENCRYPT_DECRYPT"
+ multi_region = (known after apply)
+ policy = jsonencode(
{
+ Statement = [
+ {
+ Action = "kms:*"
+ Effect = "Allow"
+ Principal = {
+ AWS = "arn:aws:iam::739275439843:root"
}
+ Resource = "*"
+ Sid = "Enable IAM User Permissions"
},
+ {
+ Action = [
+ "kms:ReEncrypt*",
+ "kms:GenerateDataKey*",
+ "kms:Encrypt*",
+ "kms:Describe*",
+ "kms:Decrypt*",
]
+ Effect = "Allow"
+ Principal = {
+ Service = "logs.ca-central-1.amazonaws.com"
}
+ Resource = "*"
},
+ {
+ Action = [
+ "kms:GenerateDataKey*",
+ "kms:Decrypt",
]
+ Effect = "Allow"
+ Principal = {
+ Service = "cloudwatch.amazonaws.com"
}
+ Resource = "*"
+ Sid = "Allow_CloudWatch_for_CMK"
},
+ {
+ Action = [
+ "kms:ReEncrypt*",
+ "kms:GenerateDataKey*",
+ "kms:Encrypt*",
+ "kms:Describe*",
+ "kms:Decrypt*",
]
+ Effect = "Allow"
+ Principal = {
+ Service = "events.amazonaws.com"
}
+ Resource = "*"
+ Sid = "CloudwatchEvents"
},
]
+ Version = "2012-10-17"
}
)
+ rotation_period_in_days = (known after apply)
+ tags_all = {
+ "CostCentre" = "PlatformDataLake"
+ "Terraform" = "true"
}
}
# aws_sns_topic.cloudwatch_alarm_action will be created
+ resource "aws_sns_topic" "cloudwatch_alarm_action" {
+ arn = (known after apply)
+ beginning_archive_time = (known after apply)
+ content_based_deduplication = false
+ fifo_topic = false
+ id = (known after apply)
+ kms_master_key_id = (known after apply)
+ name = "cloudwatch-alarm-action"
+ name_prefix = (known after apply)
+ owner = (known after apply)
+ policy = (known after apply)
+ signature_version = (known after apply)
+ tags_all = {
+ "CostCentre" = "PlatformDataLake"
+ "Terraform" = "true"
}
+ tracing_config = (known after apply)
}
# aws_sns_topic.cloudwatch_ok_action will be created
+ resource "aws_sns_topic" "cloudwatch_ok_action" {
+ arn = (known after apply)
+ beginning_archive_time = (known after apply)
+ content_based_deduplication = false
+ fifo_topic = false
+ id = (known after apply)
+ kms_master_key_id = (known after apply)
+ name = "cloudwatch-ok-action"
+ name_prefix = (known after apply)
+ owner = (known after apply)
+ policy = (known after apply)
+ signature_version = (known after apply)
+ tags_all = {
+ "CostCentre" = "PlatformDataLake"
+ "Terraform" = "true"
}
+ tracing_config = (known after apply)
}
# aws_sns_topic_policy.cloudwatch_alarm_action will be created
+ resource "aws_sns_topic_policy" "cloudwatch_alarm_action" {
+ arn = (known after apply)
+ id = (known after apply)
+ owner = (known after apply)
+ policy = jsonencode(
{
+ Statement = [
+ {
+ Action = [
+ "SNS:Subscribe",
+ "SNS:SetTopicAttributes",
+ "SNS:RemovePermission",
+ "SNS:Receive",
+ "SNS:Publish",
+ "SNS:ListSubscriptionsByTopic",
+ "SNS:GetTopicAttributes",
+ "SNS:DeleteTopic",
+ "SNS:AddPermission",
]
+ Condition = {
+ StringEquals = {
+ "AWS:SourceOwner" = "739275439843"
}
}
+ Effect = "Allow"
+ Principal = {
+ AWS = "*"
}
+ Resource = "*"
+ Sid = "SNS_Default_Policy"
},
+ {
+ Action = "sns:Publish"
+ Effect = "Allow"
+ Principal = {
+ Service = "events.amazonaws.com"
}
+ Resource = "*"
+ Sid = "SNS_Publish_statement"
},
]
+ Version = "2012-10-17"
}
)
}
# aws_sns_topic_policy.cloudwatch_ok_action will be created
+ resource "aws_sns_topic_policy" "cloudwatch_ok_action" {
+ arn = (known after apply)
+ id = (known after apply)
+ owner = (known after apply)
+ policy = jsonencode(
{
+ Statement = [
+ {
+ Action = [
+ "SNS:Subscribe",
+ "SNS:SetTopicAttributes",
+ "SNS:RemovePermission",
+ "SNS:Receive",
+ "SNS:Publish",
+ "SNS:ListSubscriptionsByTopic",
+ "SNS:GetTopicAttributes",
+ "SNS:DeleteTopic",
+ "SNS:AddPermission",
]
+ Condition = {
+ StringEquals = {
+ "AWS:SourceOwner" = "739275439843"
}
}
+ Effect = "Allow"
+ Principal = {
+ AWS = "*"
}
+ Resource = "*"
+ Sid = "SNS_Default_Policy"
},
+ {
+ Action = "sns:Publish"
+ Effect = "Allow"
+ Principal = {
+ Service = "events.amazonaws.com"
}
+ Resource = "*"
+ Sid = "SNS_Publish_statement"
},
]
+ Version = "2012-10-17"
}
)
}
# aws_sns_topic_subscription.cloudwatch_alarm_action will be created
+ resource "aws_sns_topic_subscription" "cloudwatch_alarm_action" {
+ arn = (known after apply)
+ confirmation_timeout_in_minutes = 1
+ confirmation_was_authenticated = (known after apply)
+ endpoint = (sensitive value)
+ endpoint_auto_confirms = false
+ filter_policy_scope = (known after apply)
+ id = (known after apply)
+ owner_id = (known after apply)
+ pending_confirmation = (known after apply)
+ protocol = "https"
+ raw_message_delivery = false
+ topic_arn = (known after apply)
}
# aws_sns_topic_subscription.cloudwatch_ok_action will be created
+ resource "aws_sns_topic_subscription" "cloudwatch_ok_action" {
+ arn = (known after apply)
+ confirmation_timeout_in_minutes = 1
+ confirmation_was_authenticated = (known after apply)
+ endpoint = (sensitive value)
+ endpoint_auto_confirms = false
+ filter_policy_scope = (known after apply)
+ id = (known after apply)
+ owner_id = (known after apply)
+ pending_confirmation = (known after apply)
+ protocol = "https"
+ raw_message_delivery = false
+ topic_arn = (known after apply)
}
Plan: 10 to add, 0 to change, 0 to destroy.
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Show Conftest resultsWARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.glue_crawler_error"]
WARN - plan.json - main - Missing Common Tags: ["aws_kms_key.cloudwatch"]
WARN - plan.json - main - Missing Common Tags: ["aws_sns_topic.cloudwatch_alarm_action"]
WARN - plan.json - main - Missing Common Tags: ["aws_sns_topic.cloudwatch_ok_action"]
23 tests, 19 passed, 4 warnings, 0 failures, 0 exceptions
|
patheard
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
Review
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: Branch creation - "before 4am on Monday" in timezone America/Montreal, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.