Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the --test-third-party-cookie-phaseout chrome flag #233

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

GnsP
Copy link
Contributor

@GnsP GnsP commented Nov 27, 2023

Launch Chrome using the --test-third-party-cookie-phaseout flag for e2e tests.
Ref: chrome blogpost on third party cookie phaseout

@GnsP GnsP added the build label Nov 27, 2023
@GnsP GnsP changed the title add the test third party cookie phaseout chrome flag add the --test-third-party-cookie-phaseout chrome flag Nov 27, 2023
@samdgupi
Copy link
Contributor

The blog post mentions running two parallel test runs one with and one without the flag but that would increase the time to test.
LGTM otherwise.

@@ -50,6 +50,7 @@ public class SeleniumDriver {
chromeOptions.addArguments("--no-sandbox");
chromeOptions.addArguments("--disable-setuid-sandbox");
chromeOptions.addArguments("--headless");
chromeOptions.addArguments("--test-third-party-cookie-phaseout");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a jira to remove it once the chrome rollout is done/stabilised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants