Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️🪝 update pre-commit hooks #23

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.3 → v0.4.4](astral-sh/ruff-pre-commit@v0.4.3...v0.4.4)
- [github.com/pre-commit/mirrors-clang-format: v18.1.4 → v18.1.5](pre-commit/mirrors-clang-format@v18.1.4...v18.1.5)
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 13, 2024
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy reports: 9 concern(s)
  • include/dd/ComplexTable.hpp:105:23: warning: [cppcoreguidelines-avoid-non-const-global-variables]

    variable 'zero' is non-const and globally accessible, consider making it const

      static inline Entry zero{
                          ^
  • include/dd/ComplexTable.hpp:109:23: warning: [cppcoreguidelines-avoid-non-const-global-variables]

    variable 'sqrt2_2' is non-const and globally accessible, consider making it const

      static inline Entry sqrt2_2{
                          ^
  • include/dd/ComplexTable.hpp:109:23: warning: [readability-identifier-naming]

    invalid case style for variable 'sqrt2_2'

      static inline Entry sqrt2_2{
                          ^~~~~~~
                          sqrt22
  • include/dd/ComplexTable.hpp:113:23: warning: [cppcoreguidelines-avoid-non-const-global-variables]

    variable 'one' is non-const and globally accessible, consider making it const

      static inline Entry one{
                          ^
  • include/dd/ComplexTable.hpp:523:20: warning: [cppcoreguidelines-avoid-non-const-global-variables]

    variable 'TOLERANCE' is non-const and globally accessible, consider making it const

      static inline fp TOLERANCE =
                       ^
  • include/dd/ComplexTable.hpp:523:20: warning: [readability-identifier-naming]

    invalid case style for variable 'TOLERANCE'

      static inline fp TOLERANCE =
                       ^~~~~~~~~
                       tolerance
  • include/dd/UniqueTable.hpp:103:11: warning: [cppcoreguidelines-init-variables]

    variable 'p' is not initialized

        Node* p = tables[static_cast<std::size_t>(v)][key];
              ^
                = nullptr
  • include/dd/UniqueTable.hpp:237:5: warning: [misc-const-correctness]

    variable 'collected' of type 'std::size_t' (aka 'unsigned long') can be declared 'const'

        std::size_t collected = 0;
        ^
                    const 
  • include/dd/UniqueTable.hpp:238:5: warning: [misc-const-correctness]

    variable 'remaining' of type 'std::size_t' (aka 'unsigned long') can be declared 'const'

        std::size_t remaining = 0;
        ^
                    const 

Have any feedback or feature suggestions? Share it here.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.5%. Comparing base (75846eb) to head (9b32385).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #23     +/-   ##
=======================================
- Coverage   69.7%   69.5%   -0.2%     
=======================================
  Files        105     105             
  Lines       4963    4964      +1     
  Branches     263     263             
=======================================
- Hits        3461    3452      -9     
- Misses      1502    1512     +10     
Flag Coverage Δ
cpp 73.7% <ø> (ø)
python 67.8% <100.0%> (-0.3%) ⬇️
Files Coverage Δ
include/dd/ComplexTable.hpp 60.4% <ø> (ø)
include/dd/UniqueTable.hpp 94.7% <ø> (ø)
src/mqt/qudits/quantum_circuit/circuit.py 95.6% <100.0%> (+<0.1%) ⬆️

... and 1 file with indirect coverage changes

@burgholzer burgholzer merged commit f19ac1f into main May 13, 2024
23 of 29 checks passed
@burgholzer burgholzer deleted the pre-commit-ci-update-config branch May 13, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant