Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Neutral Atom State Preparation #500

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

Integrate Neutral Atom State Preparation #500

wants to merge 56 commits into from

Conversation

ystade
Copy link
Contributor

@ystade ystade commented Aug 5, 2024

Description

It adds a new functionality to generate minimal schedules for preparing logical arrays on the neutral atom architecture.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@ystade ystade self-assigned this Aug 5, 2024
@ystade ystade added feature New feature or request c++ Anything related to C++ code minor Changes leading to a minor version increase labels Aug 5, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 95.68966% with 35 lines in your changes missing coverage. Please review.

Project coverage is 90.8%. Comparing base (fad6632) to head (42c9a53).

Files with missing lines Patch % Lines
src/na/nasp/Solver.cpp 95.5% 23 Missing ⚠️
src/na/nasp/CodeGenerator.cpp 91.5% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #500     +/-   ##
=======================================
+ Coverage   90.4%   90.8%   +0.4%     
=======================================
  Files         87      91      +4     
  Lines      10052   10868    +816     
  Branches    1722    1842    +120     
=======================================
+ Hits        9091    9876    +785     
- Misses       961     992     +31     
Flag Coverage Δ
cpp 90.6% <95.6%> (+0.4%) ⬆️
python 95.9% <ø> (ø)
Files with missing lines Coverage Δ
include/na/Architecture.hpp 100.0% <ø> (ø)
include/na/Configuration.hpp 100.0% <ø> (ø)
include/na/nalac/NAMapper.hpp 100.0% <ø> (ø)
include/na/nasp/Solver.hpp 100.0% <100.0%> (ø)
src/na/Architecture.cpp 98.0% <100.0%> (+<0.1%) ⬆️
src/na/Configuration.cpp 94.4% <ø> (ø)
src/na/nalac/NAGraphAlgorithms.cpp 94.4% <ø> (ø)
src/na/nalac/NAMapper.cpp 89.8% <ø> (ø)
src/na/nasp/SolverFactory.cpp 100.0% <100.0%> (ø)
src/na/nasp/CodeGenerator.cpp 91.5% <91.5%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

(*it)->execute();
}
}
for (std::uint16_t t = 1; t < result.numStages(); ++t) {

Check failure

Code scanning / CodeQL

Comparison of narrow type with wide type in loop condition

Comparison between [t](1) of type uint16_t and [call to numStages](2) of wider type size_t.
std::vector<std::shared_ptr<Point>> loadEndPositions;
std::vector<std::shared_ptr<Point>> storeStartPositions;
std::vector<std::shared_ptr<Point>> storeEndPositions;
for (std::uint16_t i = 0; i < result.getStage(t).numQubits(); ++i) {

Check failure

Code scanning / CodeQL

Comparison of narrow type with wide type in loop condition

Comparison between [i](1) of type uint16_t and [call to numQubits](2) of wider type size_t.
src/na/nasp/Optimizer.cpp Fixed Show fixed Hide fixed
src/na/nasp/Solver.cpp Fixed Show fixed Hide fixed
src/na/nasp/Solver.cpp Fixed Show fixed Hide fixed
src/na/nasp/Solver.cpp Fixed Show fixed Hide fixed
src/na/nasp/Solver.cpp Fixed Show fixed Hide fixed
model.eval(bv2int(stage.getQubit(i).getV(), true)).get_numeral_int());
}
std::vector<Result::Gate> resultGates;
for (std::uint16_t i = 0; i < gates.size(); ++i) {

Check failure

Code scanning / CodeQL

Comparison of narrow type with wide type in loop condition

Comparison between [i](1) of type uint16_t and [call to size](2) of wider type size_type.
src/na/nasp/Solver.cpp Fixed Show fixed Hide fixed
model.eval(bv2int(stage.getQubit(i).getV(), true)).get_numeral_int());
}
std::vector<Result::Gate> resultGates;
for (std::uint16_t i = 0; i < gates.size(); ++i) {

Check failure

Code scanning / CodeQL

Comparison of narrow type with wide type in loop condition

Comparison between [i](1) of type uint16_t and [call to size](2) of wider type size_type.
@ystade
Copy link
Contributor Author

ystade commented Aug 6, 2024

@burgholzer I know that you removed the #include <sys/wait.h> or rather replaced it by #include <wait.h>. But I do not get it to work this way. The problem is in src/na/nasp/Optimizer.cpp.

@ystade ystade marked this pull request as ready for review August 6, 2024 15:06
@ystade ystade requested a review from burgholzer August 6, 2024 15:06
@burgholzer
Copy link
Member

Note

#507 just went in and brought some updates from the MQT Core dependency that cause some conflicts here. Could you please resolve these? They should be fairly easy to resolve. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code feature New feature or request minor Changes leading to a minor version increase
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants