✨ switch to mqt-core Python package
#418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added
dependencies
burgholzer
force-pushed
the
mqt-core-switch
branch
2 times, most recently
from
57479ce
to
e05f117
Compare
This was referenced Jan 27, 2024
Merged
burgholzer
added a commit
that referenced
this pull request
Jan 29, 2024
## Description This PR updates the mqt-core submodule and brings in some further advancements from #418. Specifically, it switches to using `FetchContent` for obtaining `mqt-core` (and `LogicBlocks`). Per default, it is pointed to the vendored submodule via an overridable CMake variable. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines.
burgholzer
force-pushed
the
mqt-core-switch
branch
2 times, most recently
from
2643b7b
to
c93369f
Compare
burgholzer
force-pushed
the
mqt-core-switch
branch
from
c93369f
to
07e035d
Compare
4 tasks
burgholzer
force-pushed
the
mqt-core-switch
branch
from
07e035d
to
87a5ae8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=====================================
Coverage 90.3% 90.3%
=====================================
Files 90 90
Lines 10045 10047 +2
Branches 1711 1711
=====================================
+ Hits 9075 9077 +2
Misses 970 970
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
4 tasks
burgholzer
added
major
Signed-off-by: burgholzer <[email protected]>
burgholzer
force-pushed
the
mqt-core-switch
branch
from
87a5ae8
to
dbaa9cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches the project to use the newly developed
mqt-corePython package.Any Python package build will only require the
mqt-corepackage as a build and runtime dependency and won't have to rely on fetched version of mqt-core any more.Any regular C++ build will still use the
FetchContentCMake module.The change brings a range of advantages:
loadfunction ofmqt-corethat allows to load any supported circuit format as input and has better handling for QiskitQuantumCircuitobjects.Checklist: