Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix neutral defect handling in CDS and correct gate design termination condition. #551

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

Drewniok
Copy link
Collaborator

Description

This PR fixes two bugs:

  1. It is checked now if a defect is charged when adding it to a cds.
  2. The termination condition for Automatic Exhaustive Gate Design was missing.

Thanks to @wlambooy for reporting a strange behavior of on-the-fly defect aware layout design.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the bug Something isn't working label Oct 29, 2024
@Drewniok Drewniok self-assigned this Oct 29, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (42ba962) to head (ad7f957).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   98.22%   98.22%   -0.01%     
==========================================
  Files         228      228              
  Lines       35706    35730      +24     
  Branches     1691     1691              
==========================================
+ Hits        35072    35095      +23     
- Misses        634      635       +1     
Files with missing lines Coverage Δ
...n/algorithms/physical_design/design_sidb_gates.hpp 98.55% <100.00%> (+0.01%) ⬆️
...fiction/technology/charge_distribution_surface.hpp 99.40% <100.00%> (+<0.01%) ⬆️
...t/algorithms/physical_design/design_sidb_gates.cpp 100.00% <100.00%> (ø)
test/technology/charge_distribution_surface.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ba962...ad7f957. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@Drewniok Drewniok merged commit d3c01f9 into cda-tum:main Oct 30, 2024
61 checks passed
@Drewniok Drewniok deleted the bug_fixes branch October 30, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants