Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ Updated the atomic defect-aware SiDB physical design experiment in accordance with the final paper #330

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Nov 14, 2023

Description

This PR updates the atomic defect-aware SiDB physical design experiment in accordance with the final paper, which will be published at DATE 2024.

In particular, the experiment script was not computing the bounding box of the generated layout, leading to confusing results.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added bug Something isn't working enhancement New feature or request labels Nov 14, 2023
@marcelwa marcelwa self-assigned this Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (decdd0a) 96.02% compared to head (62e99ae) 96.02%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files         100      100           
  Lines        9973     9973           
=======================================
  Hits         9577     9577           
  Misses        396      396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit b3f9a8c into main Nov 15, 2023
57 checks passed
@marcelwa marcelwa deleted the defect-aware-sidb-physical-design-update branch November 15, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant