Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Fix minor oversights by using static constexpr and noexcept #306

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Oct 5, 2023

Description

This PR fixes minor oversights in two places that might have the possibility to slightly increase performance when heavily used.

  1. Switched from dynamic to static allocation in clocking_scheme.hpp
  2. Added missing noexcept annotations in stl_utils.hpp

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added small fix Non-critical issue or inconsistency performance Performance improvements labels Oct 5, 2023
@marcelwa marcelwa self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4cb8adb) 95.85% compared to head (4d3c5e5) 95.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   95.85%   95.83%   -0.02%     
==========================================
  Files          98       98              
  Lines        9550     9539      -11     
==========================================
- Hits         9154     9142      -12     
- Misses        396      397       +1     
Files Coverage Δ
include/fiction/layouts/clocking_scheme.hpp 97.04% <ø> (-0.19%) ⬇️
include/fiction/utils/stl_utils.hpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcelwa marcelwa merged commit 4841ae6 into main Oct 5, 2023
57 of 58 checks passed
@marcelwa marcelwa deleted the static-allocation branch October 5, 2023 13:57
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/utils/stl_utils.hpp Show resolved Hide resolved
include/fiction/utils/stl_utils.hpp Show resolved Hide resolved
include/fiction/utils/stl_utils.hpp Show resolved Hide resolved
include/fiction/utils/stl_utils.hpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvements small fix Non-critical issue or inconsistency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant