🐛 Fixed a nullptr dereference bug
#287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ference bug within the fiction library. The layout is now checked to ensure that it implements the clocking scheme before asserting that it is an obstruction layout in the `improve_gate_location` function, guarding against null reference errors. This change enhances code safety, preventing potential runtime issues that could arise from null pointer dereferencing. The changes also include an addition in reporting total runtime for post layout optimization. Additional minor code refactoring was performed for better readability and to explicitly state the layout type requirements in the template typename declarations. Lastly, code to handle optional return of stats from post layout optmization function has been added.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
- Coverage 95.42% 95.41% -0.01%
==========================================
Files 96 96
Lines 9422 9427 +5
==========================================
+ Hits 8991 8995 +4
- Misses 431 432 +1
☔ View full report in Codecov by Sentry. |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a
nullptrdereference bug.Checklist: