Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Refactored the technology mapping interface #278

Merged
merged 26 commits into from
Apr 29, 2024
Merged

🎨 Refactored the technology mapping interface #278

merged 26 commits into from
Apr 29, 2024

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Sep 6, 2023 •
edited
Loading

Description

This PR refactors the technology mapper into its own header file for better re-usability.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added enhancement New feature or request small fix Non-critical issue or inconsistency labels Sep 6, 2023
@marcelwa marcelwa self-assigned this Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.19028% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.21%. Comparing base (c6eb455) to head (555aa2c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   98.29%   98.21%   -0.08%     
==========================================
  Files         211      214       +3     
  Lines       28576    28902     +326     
  Branches     1319     1367      +48     
==========================================
+ Hits        28088    28386     +298     
- Misses        488      516      +28
Files Coverage Δ
...hms/network_transformation/fanout_substitution.cpp 100.00% <100.00%> (ø)
...thms/network_transformation/technology_mapping.cpp 100.00% <100.00%> (ø)
...thms/network_transformation/technology_mapping.hpp 98.60% <98.60%> (ø)

... and 8 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6eb455...555aa2c. Read the comment docs.

github-actions[bot]
github-actions bot reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/algorithms/network_transformation/technology_mapping.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/network_transformation/technology_mapping.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/network_transformation/technology_mapping.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/network_transformation/technology_mapping.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/network_transformation/technology_mapping.hpp Outdated Show resolved Hide resolved
test/algorithms/network_transformation/technology_mapping.cpp Outdated Show resolved Hide resolved
test/algorithms/network_transformation/technology_mapping.cpp Outdated Show resolved Hide resolved
test/algorithms/network_transformation/technology_mapping.cpp Outdated Show resolved Hide resolved
test/algorithms/network_transformation/technology_mapping.cpp Outdated Show resolved Hide resolved
test/algorithms/network_transformation/technology_mapping.cpp Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 6, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

github-actions[bot]
github-actions bot reviewed Sep 23, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

cli/cmd/logic/map.hpp Outdated Show resolved Hide resolved
include/fiction/algorithms/network_transformation/technology_mapping.hpp Show resolved Hide resolved
include/fiction/algorithms/network_transformation/technology_mapping.hpp Show resolved Hide resolved
include/fiction/algorithms/network_transformation/technology_mapping.hpp Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/algorithms/network_transformation/technology_mapping.hpp Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 28, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@marcelwa marcelwa merged commit c8b9bc3 into main Apr 29, 2024
54 checks passed
@marcelwa marcelwa deleted the tech-mapper branch April 29, 2024 21:00
github-actions[bot]
github-actions bot reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

bindings/pyfiction/include/pyfiction/algorithms/network_transformation/technology_mapping.hpp Show resolved Hide resolved
bindings/pyfiction/pyfiction.cpp Show resolved Hide resolved
bindings/pyfiction/pyfiction.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@marcelwa marcelwa

Labels
enhancement New feature or request small fix Non-critical issue or inconsistency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelwa @actions-user