Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 2DDWave Distance Fix #257

Merged
merged 5 commits into from
Jul 25, 2023
Merged

🐛 2DDWave Distance Fix #257

merged 5 commits into from
Jul 25, 2023

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Jul 24, 2023

Description

This PR fixes a potential overflow bug in twoddwave_distance.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the bug Something isn't working label Jul 24, 2023
@marcelwa marcelwa self-assigned this Jul 24, 2023
simon1hofmann
simon1hofmann previously approved these changes Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #257 (e86ecac) into main (aa68809) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files          85       85           
  Lines        7669     7669           
=======================================
  Hits         7247     7247           
  Misses        422      422           
Files Changed Coverage Δ
...clude/fiction/algorithms/path_finding/distance.hpp 100.00% <100.00%> (ø)

@marcelwa marcelwa merged commit 92bb036 into main Jul 25, 2023
56 checks passed
@marcelwa marcelwa deleted the 2ddwave-distance-fix branch July 25, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants