-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ New SiDB simulator QuickExact
and simulation of atomic defects.
#203
Conversation
Signed-off-by: ClangFormat <[email protected]>
…o sidb_temperature_simulation
Signed-off-by: ClangFormat <[email protected]>
Signed-off-by: ClangFormat <[email protected]>
Signed-off-by: ClangFormat <[email protected]>
…o sidb_temperature_simulation # Conflicts: # include/fiction/algorithms/simulation/sidb/calculate_energy_and_state_type.hpp
Signed-off-by: ClangFormat <[email protected]>
…o sidb_temperature_simulation
…icksim``. All simulation engines use ``sidb_simulation_result`` now to collect results.
Signed-off-by: ClangFormat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
test/algorithms/simulation/sidb/maximum_defect_influence_distance.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are nearing perfection! Just a couple more things to tweak.
include/fiction/algorithms/simulation/sidb/maximum_defect_influence_distance.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/maximum_defect_influence_distance.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/maximum_defect_influence_distance.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/maximum_defect_influence_distance.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/maximum_defect_influence_distance.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/maximum_defect_influence_distance.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/maximum_defect_influence_distance.hpp
Outdated
Show resolved
Hide resolved
test/algorithms/simulation/sidb/maximum_defect_influence_distance.cpp
Outdated
Show resolved
Hide resolved
test/algorithms/simulation/sidb/maximum_defect_influence_position_and_distance.cpp
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/simulation/sidb/critical_temperature.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/maximum_defect_influence_position_and_distance.hpp
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/time_to_solution.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/maximum_defect_influence_position_and_distance.hpp
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Description
This is an extensive PR with several new features: 1.) A new exact simulation algorithm (QuickExact) to simulate SiDB layouts is implemented. 2.) Defect simulation is added. 3.) Simulation of External Potentials.
Checklist: