Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ New SiDB simulator QuickExact and simulation of atomic defects. #203

Merged
merged 389 commits into from
Sep 12, 2023

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented May 5, 2023

Description

This is an extensive PR with several new features: 1.) A new exact simulation algorithm (QuickExact) to simulate SiDB layouts is implemented. 2.) Defect simulation is added. 3.) Simulation of External Potentials.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

ClangFormat and others added 30 commits April 25, 2023 13:23
Signed-off-by: ClangFormat <[email protected]>
Signed-off-by: ClangFormat <[email protected]>
Signed-off-by: ClangFormat <[email protected]>
Signed-off-by: ClangFormat <[email protected]>
…o sidb_temperature_simulation

# Conflicts:
#	include/fiction/algorithms/simulation/sidb/calculate_energy_and_state_type.hpp
Signed-off-by: ClangFormat <[email protected]>
…icksim``. All simulation engines use ``sidb_simulation_result`` now to collect results.
Signed-off-by: ClangFormat <[email protected]>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are nearing perfection! Just a couple more things to tweak.

@Drewniok Drewniok requested review from marcelwa and removed request for marcelwa September 8, 2023 12:11
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/fiction/technology/charge_distribution_surface.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@marcelwa marcelwa merged commit c5812a1 into cda-tum:main Sep 12, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants