✨ Added function to generate random SiDB layouts and write simulation results to file. #200

Drewniok · 2023-05-04T14:31:02Z

Description

This PR adds a workflow to generate random SiDB layouts. The layouts are made compatible with SiQAD and the corresponding simulation results are provided.

Checklist:

The pull request only contains commits that are related to it.
I have added appropriate tests and documentation.
I have made sure that all CI jobs on GitHub pass.
The pull request introduces no new warnings and follows the project's style guidelines.

Bumps [libs/Catch2](https://github.com/catchorg/Catch2) from `6783411` to `1f881ab`. - [Release notes](https://github.com/catchorg/Catch2/releases) - [Commits](catchorg/Catch2@6783411...1f881ab) --- updated-dependencies: - dependency-name: libs/Catch2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [libs/parallel-hashmap](https://github.com/greg7mdp/parallel-hashmap) from `7883cb6` to `d2bed96`. - [Release notes](https://github.com/greg7mdp/parallel-hashmap/releases) - [Commits](greg7mdp/parallel-hashmap@7883cb6...d2bed96) --- updated-dependencies: - dependency-name: libs/parallel-hashmap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…the simulation results as text files.

codecov · 2023-05-04T15:01:03Z

Codecov Report

Merging #200 (0f54bfc) into main (b352aaf) will increase coverage by 0.01%.
The diff coverage is 96.20%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   94.54%   94.56%   +0.01%     
==========================================
  Files          83       85       +2     
  Lines        7586     7667      +81     
==========================================
+ Hits         7172     7250      +78     
- Misses        414      417       +3

Impacted Files	Coverage Δ
...rithms/simulation/sidb/random_layout_generator.hpp	`93.02% <93.02%> (ø)`
include/fiction/io/write_sqd_layout.hpp	`100.00% <100.00%> (ø)`
include/fiction/io/write_txt_sim_result.hpp	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b352aaf...0f54bfc. Read the comment docs.

github-actions

clang-tidy made some suggestions

experiments/random_layout_generation/random_layout_generation.cpp

test/algorithms/simulation/sidb/random_layout_generator.cpp

github-actions

clang-tidy made some suggestions

experiments/random_layout_generation/random_layout_generation.cpp

experiments/random_layout_generation/simulation_result_file.cpp

experiments/random_layout_generation/random_layout_generation.cpp

include/fiction/io/write_loc_sim_result.hpp

test/io/write_loc_sim_result.cpp

include/fiction/io/write_loc_sim_result.hpp

github-actions

clang-tidy made some suggestions

experiments/random_sidb_layout_generation/random_sidb_layout_generation.cpp

experiments/random_sidb_layout_generation/sidb_location_and_ground_state_simulation.cpp

marcelwa · 2023-09-04T13:59:00Z

@Drewniok please incorporate the bots' comments first. Afterward, I will gladly review it again.

github-actions · 2023-09-04T14:52:09Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions

clang-tidy made some suggestions

include/fiction/algorithms/simulation/sidb/random_sidb_layout_generator.hpp

github-actions · 2023-09-05T07:40:00Z

clang-tidy review says "All clean, LGTM! 👍"

include/fiction/io/write_location_and_ground_state.hpp

test/algorithms/simulation/sidb/random_sidb_layout_generator.cpp

github-actions · 2023-09-05T13:13:37Z

clang-tidy review says "All clean, LGTM! 👍"

marcelwa

Many thanks for the great additions!

dependabot bot and others added 23 commits April 2, 2023 15:38

Merge branch 'marcelwa:main' into main

2da4f7e

Merge branch 'marcelwa:main' into main

a8cbc27

Merge branch 'marcelwa:main' into main

3b11f93

Merge branch 'marcelwa:main' into main

e9e2fa3

Merge branch 'marcelwa:main' into main

37c881e

Merge branch 'marcelwa:main' into main

4aa8489

Merge branch 'marcelwa:main' into main

1587ef3

Merge branch 'marcelwa:main' into main

04ed1c3

Merge branch 'marcelwa:main' into main

9eaaf1f

Merge branch 'marcelwa:main' into main

0dca9cf

Merge branch 'marcelwa:main' into main

ce8b2e2

✨ random layout generator.

cf70745

✨ random layout generator.

58d5f12

✅ add test for random layout generator.

8a5efa3

✅ update test.

0109e2b

✨ experiment file to generate random layouts.

5174cc9

✨ experiment file to simulate the randomly-generated files and store …

6e7e8b3

…the simulation results as text files.

📝 add RST.

0236e84

📝 small change in RST.

25e8b6b

📝 remove superfluous semicolon.

6053844

📝 add missing @param.

bb2d756

📝 add missing doxygenstruct.

17377a4

github-actions bot reviewed May 4, 2023

View reviewed changes

Drewniok added 4 commits May 4, 2023 18:25

🎨 add const keyword.

9859049

🎨 remove const keyword.

f38f6bd

🎨 small changes.

5bd0e28

🎨 add const.

d70a8a6

Drewniok and others added 5 commits August 30, 2023 14:07

Merge branch 'cda-tum:main' into main

918b755

Merge branch 'cda-tum:main' into main

89bc9ae

Merge branch 'main' into random_layout_generator

11b61ae

🔀 merge main.

eb84e84

🔀 merge main.

fe94fd5

github-actions bot reviewed Sep 4, 2023

View reviewed changes

marcelwa requested changes Sep 4, 2023

View reviewed changes

Drewniok added 6 commits September 4, 2023 14:14

🎨 implement review suggestions.

8625fc8

🎨 implement review suggestions.

b9c531f

🐛 wrong Header in sidb_simulation.rst.

86dd321

🎨 renaming for documentation.

4c18389

🎨 renaming for documentation.

188929b

🎨 reformat code.

3fcd565

Drewniok requested a review from marcelwa September 4, 2023 13:15

github-actions bot reviewed Sep 4, 2023

View reviewed changes

🎨 Incorporate the bots' comments.

654f049

Drewniok added 2 commits September 5, 2023 09:07

🎨 more consistency

13444d6

🎨 remove static_assert

8a90cdf

github-actions bot reviewed Sep 5, 2023

View reviewed changes

github-advanced-security bot found potential problems Sep 5, 2023

View reviewed changes

Drewniok and others added 3 commits September 5, 2023 12:49

🎨 use std::fabs to check equality.

dd5da41

Merge branch 'cda-tum:main' into main

64c4862

Merge branch 'main' into random_layout_generator

4746672

marcelwa approved these changes Sep 5, 2023

View reviewed changes

marcelwa merged commit 424564f into cda-tum:main Sep 5, 2023
56 checks passed

Drewniok deleted the random_layout_generator branch September 5, 2023 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Added function to generate random SiDB layouts and write simulation results to file. #200

✨ Added function to generate random SiDB layouts and write simulation results to file. #200

Drewniok commented May 4, 2023

codecov bot commented May 4, 2023 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

marcelwa commented Sep 4, 2023 •

edited

Loading

github-actions bot commented Sep 4, 2023

github-actions bot left a comment

github-actions bot commented Sep 5, 2023

github-actions bot commented Sep 5, 2023

marcelwa left a comment

✨ Added function to generate random SiDB layouts and write simulation results to file. #200

✨ Added function to generate random SiDB layouts and write simulation results to file. #200

Conversation

Drewniok commented May 4, 2023

Description

Checklist:

codecov bot commented May 4, 2023 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

marcelwa commented Sep 4, 2023 • edited Loading

github-actions bot commented Sep 4, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 5, 2023

github-actions bot commented Sep 5, 2023

marcelwa left a comment

Choose a reason for hiding this comment

codecov bot commented May 4, 2023 •

edited

Loading

marcelwa commented Sep 4, 2023 •

edited

Loading