Replacing cmake with meson (WIP) #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed Version and folded in the major/minor/patch ints and related comparisons into PackageVersion - added language version min and max: the PackageVersion now works with a range of version. language_version_min sets the lowest compatible verison of chuck the package will work with (inclusive). language_version_max is optional. If it is set, it sets the highest compatible verison of chuck (inclusive). If it's not set, all versions of chuck >= language_version_min are compatible.
- reworked dependency injection so that there's no implicit logic involving install dir or os. - found a couple bugs - trying to download a fail that doesn't exist should result in an error, instead it makes an html file saying it failed - chump update doesn't update to a new verison.json file
now movement of downloads from temp dir to install dir is handled by manager, which means if a download fails, the whole installation fails and there isn't any partially downloaded packages in the .chump dir
throw exception if PackageList can't be opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing out replacing cmake with meson, because it sucks less.
The PR is just for test out GHA currently