Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Gelman Rubin Statistics to MARK02 #163

Merged
merged 14 commits into from
Aug 31, 2023
Merged

Adding Gelman Rubin Statistics to MARK02 #163

merged 14 commits into from
Aug 31, 2023

Conversation

gordonkoehn
Copy link
Collaborator

@gordonkoehn gordonkoehn commented Aug 31, 2023 •
edited
Loading

To more formally address convergence in the MARK02 experiment we employ the Gelman-Rubin Statistic on the tree-distance measures, AD and DL in this PR.

  • implement the Gelman-Rubin Statistic
  • integrate it into the MARK02 Workflow

@gordonkoehn gordonkoehn linked an issue Aug 31, 2023 that may be closed by this pull request
Add Gelman-Rubin Statistics #161
Closed
@gordonkoehn gordonkoehn self-assigned this Aug 31, 2023
@gordonkoehn
Copy link
Collaborator Author

Example for large noise (0.1, 0.1). both AD and DL on one plot, with horizontal lines at the conventional limits of convergence.

Screenshot 2023-08-31 at 15 44 27

gordonkoehn
gordonkoehn commented Aug 31, 2023
View reviewed changes
Copy link
Collaborator Author

@gordonkoehn gordonkoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am satisfied with the that implementation, and we will now get convergence plots for the AD and DL and combined for the MARK02 experiment, but the MARK02 snakemake workflow is certainly messy now.

src/pyggdrasil/analyze/_rhat.py Show resolved Hide resolved
src/pyggdrasil/visualize/__init__.py Show resolved Hide resolved
workflows/mark02.smk Show resolved Hide resolved
workflows/mark02.smk Show resolved Hide resolved
workflows/mark02.smk Show resolved Hide resolved
@gordonkoehn gordonkoehn mentioned this pull request Aug 31, 2023
Closed
@gordonkoehn gordonkoehn marked this pull request as ready for review August 31, 2023 14:58
@gordonkoehn gordonkoehn mentioned this pull request Aug 31, 2023
Closed
@gordonkoehn gordonkoehn linked an issue Aug 31, 2023 that may be closed by this pull request
Fix Position of Legend of MARK02 plots #159
Closed
pawel-czyz
pawel-czyz approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@pawel-czyz pawel-czyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

src/pyggdrasil/visualize/_mcmc.py Show resolved Hide resolved
src/pyggdrasil/visualize/_mcmc.py Show resolved Hide resolved
tests/analyze/test_rhat.py Show resolved Hide resolved
workflows/mark02.smk Show resolved Hide resolved
@gordonkoehn gordonkoehn merged commit 9d1d1a8 into main Aug 31, 2023
1 check passed
@gordonkoehn gordonkoehn deleted the gordon/gelman-rubin-statistics branch August 31, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawel-czyz pawel-czyz pawel-czyz approved these changes

Assignees

@gordonkoehn gordonkoehn

Labels
🦾 action: enhancement New feature or request ❗priority: high ⏰ time estimate: L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Gelman-Rubin Statistics Fix Position of Legend of MARK02 plots
2 participants
@gordonkoehn @pawel-czyz