Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit default style for popups #447

Closed
wants to merge 1 commit into from
Closed

Conversation

SfinxNT
Copy link
Contributor

@SfinxNT SfinxNT commented Dec 8, 2024

The current setup can cause style inconsistencies between popups and other windows/elements, particularly when using transparent backgrounds.

This change will resolve that issue (popups will inherit default colors for foreground and background).

Since this plugin doesn't utilize window-active-style or menu-style, there's no need for popup-style either.

@SfinxNT
Copy link
Contributor Author

SfinxNT commented Dec 8, 2024

Before:
Screenshot_20241208_190420

After:
Screenshot_20241208_190527

Copy link

@b11e b11e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump

I came from trying to get tmux sessionx manager to be transparent

Hi, sorry for the ping
@kjnsn can you take a look when you get a chance

Appreciate all the work

@kjnsn
Copy link
Collaborator

kjnsn commented Dec 20, 2024

I'm sympathetic to personal taste with regards to what colors things should be. At the same time the entire point of this repo is to be opinionated about what colors things should be in tmux. So I'm hesitant to remove colors and just use defaults, especially when catppuccin has a style guide about what things like pop-ups should look like.

@kjnsn kjnsn closed this Dec 20, 2024
@b11e
Copy link

b11e commented Dec 20, 2024

I'm sympathetic to personal taste with regards to what colors things should be. At the same time the entire point of this repo is to be opinionated about what colors things should be in tmux. So I'm hesitant to remove colors and just use defaults, especially when catppuccin has a style guide about what things like pop-ups should look like.

So how can I target the bg in my conf to use default?
Is there an option I'm missing somewhere?

Edit: shall i open a new thread?

@kjnsn
Copy link
Collaborator

kjnsn commented Dec 21, 2024

Just set the tmux option after you load catppuccin

@b11e
Copy link

b11e commented Jan 7, 2025

Just set the tmux option after you load catppuccin

I have this after running tpm

set -g status-bg default
set -g status-style bg=default

but it doesn't target the floating pane bg, i guess it's something in sessionx that's the issue?

@SfinxNT
Copy link
Contributor Author

SfinxNT commented Jan 7, 2025

Just set the tmux option after you load catppuccin

I have this after running tpm

set -g status-bg default
set -g status-style bg=default

but it doesn't target the floating pane bg, i guess it's something in sessionx that's the issue?

sessionx uses fzf under the hood to "draw" a popup window, fzf will inherit style from tmux for bg if it is not specified directly in fzf config.

So, for transparent bg in fzf/sessionx you need to set

set-option -wg popup-style bg=default

And this should be after catppuccin set it to "bg=#{@thm_bg},fg=#{@thm_fg}". so, after running tpm

@b11e
Copy link

b11e commented Jan 10, 2025

Just set the tmux option after you load catppuccin

I have this after running tpm

set -g status-bg default
set -g status-style bg=default

but it doesn't target the floating pane bg, i guess it's something in sessionx that's the issue?

sessionx uses fzf under the hood to "draw" a popup window, fzf will inherit style from tmux for bg if it is not specified directly in fzf config.

So, for transparent bg in fzf/sessionx you need to set

set-option -wg popup-style bg=default

And this should be after catppuccin set it to "bg=#{@thm_bg},fg=#{@thm_fg}". so, after running tpm

Thank you, this solved it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants