Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rebalance colors, adhere to style guide & overhaul docs #372

Merged
merged 25 commits into from
Oct 21, 2024
Merged

Conversation

kjnsn
Copy link
Collaborator

@kjnsn kjnsn commented Oct 13, 2024

No description provided.

@kjnsn kjnsn marked this pull request as ready for review October 13, 2024 07:34
@kjnsn kjnsn requested review from sgoudham and vdbe October 13, 2024 07:36
Copy link
Contributor

@vdbe vdbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this issue on my side.

The default (just running the plugin) and config 3 break with these changes.

  • Default
    image
    image
  • Config 3
    image
    image

Example config 2 is still broken with these changes, this should be fixed before releasing 2.0.

The example configs should also contain set -g status-right-length 100 since many people will just copy it an make an issue that it doesn't work.

README.md Outdated Show resolved Hide resolved
catppuccin_tmux.conf Show resolved Hide resolved
@kjnsn
Copy link
Collaborator Author

kjnsn commented Oct 15, 2024

The default (just running the plugin) and config 3 break with these changes.

Example config 2 is still broken with these changes, this should be fixed before releasing 2.0.

I am unable to replicate the color issues using alacritty on macos

@vdbe
Copy link
Contributor

vdbe commented Oct 15, 2024

The default (just running the plugin) and config 3 break with these changes.
Example config 2 is still broken with these changes, this should be fixed before releasing 2.0.

I am unable to replicate the color issues using alacritty on macos

I found the issue, it's on my side I loaded the main branch and then switched to this PR to see the diff, without switching it's gone.

Option names have been changed to be more intuitive and more closely follow
the tmux naming conventions.

Renamed:
@catppuccin_window_current_background -> @catppuccin_window_current_number_color
@catppuccin_window_current_color      -> @catppuccin_window_current_text_color
@catppuccin_window_default_background -> @catppuccin_window_number_color
@catppuccin_window_default_color      -> @catppuccin_window_text_color

Removed:
@catppuccin_window_default_fill, @catppuccin_window_current_fill
Just set the number and text colors.
docs: change the stack style for the preview, add flavor previews
docs: update links in the getting started guide
docs: restructure the docs folder
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this PR, really appreciated!

I've left a bunch of comments suggesting changes / asking for your opinion which I think are easy enough to resolve without blocking this PR for too long.

Hope that's okay!

.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/explanation/design.md Show resolved Hide resolved
docs/reference/configuration.md Outdated Show resolved Hide resolved
docs/tutorials/01-getting-started.md Outdated Show resolved Hide resolved
@kjnsn kjnsn requested a review from sgoudham October 19, 2024 04:46
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks again for taking the time to rework this repository.

@sgoudham sgoudham changed the title Rebalance the colors used, and follow the styleguide feat!: rebalance colors, adhere to style guide & overhaul docs Oct 19, 2024
@kjnsn kjnsn merged commit 79284da into main Oct 21, 2024
2 checks passed
@github-actions github-actions bot deleted the v2 branch October 21, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants