-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rebalance colors, adhere to style guide & overhaul docs #372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore this issue on my side.
The default (just running the plugin) and config 3 break with these changes.
Example config 2 is still broken with these changes, this should be fixed before releasing 2.0.
The example configs should also contain set -g status-right-length 100
since many people will just copy it an make an issue that it doesn't work.
I am unable to replicate the color issues using alacritty on macos |
I found the issue, it's on my side I loaded the main branch and then switched to this PR to see the diff, without switching it's gone. |
70961f3
to
5f37563
Compare
Option names have been changed to be more intuitive and more closely follow the tmux naming conventions. Renamed: @catppuccin_window_current_background -> @catppuccin_window_current_number_color @catppuccin_window_current_color -> @catppuccin_window_current_text_color @catppuccin_window_default_background -> @catppuccin_window_number_color @catppuccin_window_default_color -> @catppuccin_window_text_color Removed: @catppuccin_window_default_fill, @catppuccin_window_current_fill Just set the number and text colors.
docs: change the stack style for the preview, add flavor previews
docs: update links in the getting started guide
docs: restructure the docs folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work on this PR, really appreciated!
I've left a bunch of comments suggesting changes / asking for your opinion which I think are easy enough to resolve without blocking this PR for too long.
Hope that's okay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks again for taking the time to rework this repository.
No description provided.