chore: improve testing #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vdbe
commented
Sep 15, 2024
vdbe
commented
- fail tests if test scripts exit's with none 0 code
- don't expand option by default
- check all if colors are expanded
- check if module text is not expanded
vdbe
commented
Sep 15, 2024
Comment on lines
+13
to
+17
| print_option @catppuccin_status_application | grep -q "$application_text" || | ||
| echo "@catppuccin_status_application expanded @catppuccin_application_text more than once" | ||
|
|
||
| print_option @catppuccin_status_application | grep -q "@thm_" && | ||
| echo "@catppuccin_status_application did not expand all colors" |
There was a problem hiding this comment.
maybe add a die function in helpers that takes a msg and exit's with 1?
currently it fails on diff with expected
- fail tests if test scripts exit's with none 0 code - don't expand option by default - check all if colors are expanded - check if module text is not expanded
vdbe
force-pushed
the
chore/tmux-native/improve-testing
branch
from
58f1029
to
76a7b0c
Compare
kjnsn
added a commit
that referenced
this pull request
Sep 30, 2024
refactor!: Rewrite to use native tmux configuration (#306) Co-authored-by: vdbe <[email protected]> * Apply tmux.tera and comment suggestions from code review * Cleanup test harness * Make tests work for multiple lines * Add a test helper script * Add status line theming * Fix shellcheck errors * Fix test errors --------- Co-authored-by: vdbe <[email protected]> * Use the full pallete to allow for user customisation * First working tmux-native config * Follow the style guide and add popup styling * fix: `thm_gray`` -> `thm_surface_0`` (#312) Color names were replaced with upstream names. * Make the status line application module work * Fix tests * Add test for the application module * chore: replace `@message_background` with an hidden variable (#313) * Only set menu styling and popup styling on versions >= 3.4 * Always run the test tmux server under bash * Convert session and load modules * fix: test application use placeholder Replace the commands with a known placeholder, this makes the tests independent of a users preferred shell. * chore: improve testing (#314) - fail tests if test scripts exit's with none 0 code - don't expand option by default - check all if colors are expanded - check if module text is not expanded * Feat/tmux native/status modules (#315) * chore: improve testing - fail tests if test scripts exit's with none 0 code - don't expand option by default - check all if colors are expanded - check if module text is not expanded * feat(status): more modules * Add style for window statuses * Format readme.md with markdownlint * Add slanted and rounded options for the window status * Fix the application module test to ensure it works on macos * Port window status separators and colours * Remove dead code that is no longer used * Expand installation instructions in the readme * feat: more modules * Support pane styling * update pane styling information and colour values in the readme * Add all window styling options * Connect status separators when enabled * Update readme regarding modules * fix(session): add missing # * fixup! fix(session): add missing # * fix(status): works for all example/default configs * feat(status): middle separator * feat(status/window): icons (#320) * feat(status/window): icons * chore: update icon order comments * Fix the status module builder and tests * fix: remove forgotten misplaced line * Update the docs regarding custom modules and tidy up some formatting * Ensure the tmux server is destroyed when the test exits * fix(status): set status-left/right-length correctly * docs: update readme * fix: pane-format (#322) * fix(window): ensure the window styling options work * Fix the example configs in the readme --------- Co-authored-by: vdbe <[email protected]> Co-authored-by: vdbewout <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.