Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EIA MECS on GHA #578

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix EIA MECS on GHA #578

wants to merge 2 commits into from

Conversation

cmgosnell
Copy link
Member

@cmgosnell cmgosnell commented Feb 4, 2025

Overview

Closes #XXXX.

What problem does this address?
eia mecs runs fine locally but has been getting access denied errors on the GHA. I also added the same little "check if this file we downloaded is actually an html redirect"

What did you change in this PR?
i added a header mirrored off of @krivard 's situation for doelead.

Testing

How did you make sure this worked? How can a reviewer verify this?
i ran the archive via gha here
which made a draft archive here

To-do list

Tasks

Preview Give feedback

@cmgosnell cmgosnell marked this pull request as ready for review February 4, 2025 16:13
@cmgosnell cmgosnell requested a review from e-belfer February 4, 2025 16:13
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly this looks great. There's one link that is marked as skipped but when I click on it doesn't redirect as expected: https://www.eia.gov/consumption/manufacturing/data/2006/xls/RSETable3_2.xls

And indeed that table is missing from the zipped file. This seems undesirable. Any thoughts on why this is happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants