Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

落ちたクライアントがいると進行できないバグの修正 #146

Merged
merged 7 commits into from
Dec 13, 2021
Merged

落ちたクライアントがいると進行できないバグの修正 #146

merged 7 commits into from
Dec 13, 2021

Conversation

ras0q
Copy link
Member

@ras0q ras0q commented Dec 13, 2021

  • ♻️ send errorをいい感じにする
  • 🐛 落ちたクライアントがいると進行できなかった refs: 進行不可能バグ #137

@ras0q ras0q requested a review from trasta298 December 13, 2021 07:31
@ras0q
Copy link
Member Author

ras0q commented Dec 13, 2021

PRわければよかった、ごめん:pray:

trasta298
trasta298 requested changes Dec 13, 2021
View reviewed changes
usecases/service/ws/handler.go Outdated Show resolved Hide resolved
trasta298
trasta298 requested changes Dec 13, 2021
View reviewed changes
usecases/service/ws/handler.go Outdated Show resolved Hide resolved
trasta298
trasta298 approved these changes Dec 13, 2021
View reviewed changes
usecases/service/ws/handler.go Outdated Show resolved Hide resolved
@trasta298
Copy link
Member

言い訳すると使わないもの(random.OdaiExample())を作るの無駄なリソース使うから解釈合わずに勘違いしました……

@ras0q
Copy link
Member Author

ras0q commented Dec 13, 2021

う、確かにそれはそうなのでもっかいrevertしてもいいｙｐ
マージは任せます

@trasta298
Copy link
Member

revert芸人になってしまった

@trasta298 trasta298 merged commit 49b8390 into main Dec 13, 2021
@trasta298 trasta298 deleted the fix/move-without-unregistered-client branch December 13, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasta298 trasta298 trasta298 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ras0q @trasta298