GH-5058: Handle payment fix #5063
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This apparently fixes some rust-analyzer issues I was encountering without introducing too many code fixes related to clippy/fmt etc.
This change will take payment field if detected transaction is of "Deploy" variant, and changes the handle payment to properly clear the named key.
mpapierski
requested review from
zajko,
darthsiroftardis,
EdHastingsCasperAssociation and
igor-casper
darthsiroftardis
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes custom payment under
Transaction::Deployvariant which incorrectly took session bytes, rather than payment field. Additionally, it does properly remove the named key when payment is finalized.Closes #5058