Changed from enum to struct, moved variant as a variant which allo… #4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of GetRequest which allowed to promote state_identifier to a field directly in GlobalStateRequest
zajko
force-pushed
the
restructuring_global_state_request
branch
from
90aaf75
to
94134be
Compare
zajko
requested review from
EdHastingsCasperAssociation,
mpapierski,
fizyk20 and
darthsiroftardis
binary_port/src/state_request.rs
Outdated
| pub struct GlobalStateRequest { | ||
| /// Global state identifier, `None` means "latest block state". | ||
| state_identifier: Option<GlobalStateIdentifier>, | ||
| /// ualifier that points to a specific item (or items) in the global state. |
There was a problem hiding this comment.
missing leading q for qualifier
EdHastingsCasperAssociation
approved these changes
Oct 15, 2024
added 2 commits
October 21, 2024 14:22
|
bors r+ |
|
Build succeeded: |
casperlabs-bors-ng
bot
merged commit b875b1e
into
casper-network:feat-2.0
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…wed to promote to a field directly on
Please consider the following when creating a PR: